Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sophisticated approach for managing store logos #222

Open
vogti opened this issue Apr 30, 2020 · 3 comments
Open

More sophisticated approach for managing store logos #222

vogti opened this issue Apr 30, 2020 · 3 comments
Assignees
Labels
A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-easy P-low Priority: Low

Comments

@vogti
Copy link
Member

vogti commented Apr 30, 2020

Currently, the logos used in the store view in the Polypheny-UI are stored in the sources of the UI itself. All other information (description, store name) is defined in the store implementation itself. In order to simplify the process of adding new stores it would make sense to also store the logos in Polypheny-DB sources together with the adapter implementation.

@vogti vogti added C-enhancement Category: An issue proposing an enhancement A-ui Area: UI A-stores E-easy P-low Priority: Low labels Apr 30, 2020
@vogti vogti added A-db Area: DB and removed A-stores A-db Area: DB labels Mar 10, 2021
@malikrafsan
Copy link

malikrafsan commented Mar 30, 2024

Hi @vogti , my name is Malik, I want to take this issue. Is it still possible? As far as I understand the issue, this issue is about the implementation of logo path discovery is on the frontend (Polypheny-UI) [screenshot1] whereas the name, description, and other information are on the Polypheny-DB [screenshot2]. We want to move the logo path information to be on the Polypheny-DB as well, right?

My proposed solution is to add new property, "logo", on the AdapterProperties, containing the logo information

    @AdapterProperties(
            name = "MongoDB",
            description = "MongoDB is a document-oriented database system.",
            logo="mongodb.png",
            usedModes = { DeployMode.REMOTE, DeployMode.DOCKER },
            defaultMode = DeployMode.DOCKER)

And then, change the getLogo function implementation to be only appending the base path of the assets

getLogo(adapterLogo: string) {
    const basepathLogo = ... // directory of static file serving Polypheny-DB
    return `${basepathLogo}/${adapterLogo}`
}

getLogo(adapter.adapterlogo) 

I will also move the assets (images) to the Polypheny-DB, as the configuration of the logo comes from Polypheny-DB

I will try to solve this issue, please let me know if you have any concern, thank you so much in advanced!

[screenshot1]
image

[screenshot2]
image

@vogti
Copy link
Member Author

vogti commented Apr 2, 2024

Hi @malikrafsan, welcome to Polypheny. I have assigned the issue to you.
Yes, however, you need to serve the logo so that the client can download it. The idea is to avoid adjusting the UI every time we add a data store or data source.

@malikrafsan
Copy link

Thank you so much for assigning this issue to me!

I see, I will move the logo to Polypheny-DB and serve it as static files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-easy P-low Priority: Low
Projects
None yet
Development

No branches or pull requests

2 participants