You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the logos used in the store view in the Polypheny-UI are stored in the sources of the UI itself. All other information (description, store name) is defined in the store implementation itself. In order to simplify the process of adding new stores it would make sense to also store the logos in Polypheny-DB sources together with the adapter implementation.
The text was updated successfully, but these errors were encountered:
Hi @vogti , my name is Malik, I want to take this issue. Is it still possible? As far as I understand the issue, this issue is about the implementation of logo path discovery is on the frontend (Polypheny-UI) [screenshot1] whereas the name, description, and other information are on the Polypheny-DB [screenshot2]. We want to move the logo path information to be on the Polypheny-DB as well, right?
My proposed solution is to add new property, "logo", on the AdapterProperties, containing the logo information
@AdapterProperties(
name = "MongoDB",
description = "MongoDB is a document-oriented database system.",
logo="mongodb.png",
usedModes = { DeployMode.REMOTE, DeployMode.DOCKER },
defaultMode = DeployMode.DOCKER)
And then, change the getLogo function implementation to be only appending the base path of the assets
getLogo(adapterLogo: string){constbasepathLogo= ... // directory of static file serving Polypheny-DBreturn`${basepathLogo}/${adapterLogo}`}getLogo(adapter.adapterlogo)
I will also move the assets (images) to the Polypheny-DB, as the configuration of the logo comes from Polypheny-DB
I will try to solve this issue, please let me know if you have any concern, thank you so much in advanced!
Hi @malikrafsan, welcome to Polypheny. I have assigned the issue to you.
Yes, however, you need to serve the logo so that the client can download it. The idea is to avoid adjusting the UI every time we add a data store or data source.
Currently, the logos used in the store view in the Polypheny-UI are stored in the sources of the UI itself. All other information (description, store name) is defined in the store implementation itself. In order to simplify the process of adding new stores it would make sense to also store the logos in Polypheny-DB sources together with the adapter implementation.
The text was updated successfully, but these errors were encountered: