Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all Java related errors facing the user #404

Open
hennlo opened this issue Feb 28, 2022 · 3 comments
Open

Remove all Java related errors facing the user #404

hennlo opened this issue Feb 28, 2022 · 3 comments
Labels
A-db Area: DB A-ui Area: UI C-bug Category: This is a bug. E-medium P-low Priority: Low

Comments

@hennlo
Copy link
Member

hennlo commented Feb 28, 2022

Operating System (Polypheny-DB)

Linux, Windows, macOS

Polypheny-DB Version

v.0.7.0

Affected Areas

DB, UI

Browser

Chrome, Firefox, Safari, Edge, Opera

Client Operating System

No response

Bug description

DISCLAIMER:
This is somewhat simply not implemented rather than a Bug but it is desirable to receive clear output in the near future.

Whenever an error occurs the response given to the user should clearly state what was wrong, even syntax wise.
However for some cases the Java Error is still returned.

E.g. when creating a table with a type that is not supported or is simply misspelled.

image
This is a specific example of a response that is not desired but is also valid for others.

Reproduction Steps

Execute a SQL Statement like:
create table dummy (id INTERGER NOT NULL, PRIMARY KEY(id))

Expected Behavior

Return a clear description what the error was and maybe how it can be resolved.
E.g.: in the case described above something like:
line 1 column 5. Type: 'INTERGER' is not a supported PolyType

Relevant log output

Error:
Cannot invoke "org.polypheny.db.type.PolyType.getFamily()" because the return value of "org.polypheny.db.sql.sql.SqlDataTypeSpec.getType()" is null
@hennlo hennlo added C-bug Category: This is a bug. A-db Area: DB A-ui Area: UI E-medium P-low Priority: Low labels Feb 28, 2022
@ritikBhandari
Copy link

Hi @hennlo,
Can I take up on this issue if nobody is working on it?

@hennlo
Copy link
Member Author

hennlo commented Jun 3, 2022

Hi @ritikBhandari, sadly that issue is somewhat ill-defined and quite extenssive in terms of workload.
It does not only revolve around the issue mentioned in the issue itself, but really all possible errors that are exposed to the user.
Since the codebase is quite large I think this issue will be easier if you have already worked with the issue.
(Although I don't want to discourage you, you could just simply start with the issue listed above and work yourself towards a comprehensive solution)

However If you still would like to contribute (which is very appreiciated) you can also start with a minor issue and work yourself into the codebase and then move back to this issue.

  • Cheers :)

@AbhinavMir
Copy link

@hennlo A good idea would probably to write a fuzzing test system that runs a bunch of SQL commands and reports and appends the errors somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Area: DB A-ui Area: UI C-bug Category: This is a bug. E-medium P-low Priority: Low
Projects
None yet
Development

No branches or pull requests

3 participants