Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing? #366

Closed
simonask opened this issue Mar 12, 2025 · 2 comments · Fixed by #367
Closed

Tests are failing? #366

simonask opened this issue Mar 12, 2025 · 2 comments · Fixed by #367

Comments

@simonask
Copy link
Contributor

Hi! Tests are currently failing, both locally and on CI.

Rerunning the tests with env GENERATE_IMAGES=1 generates new reference images, and it looks like the only difference is that the contents of the new images are moved left by 1 pixel.

Is this change expected, and why were the reference images not updated?

To be clear, the tests start to pass without issue with the new reference images (i.e. unsetting GENERATE_IMAGES and rerunning cargo test).

@jackpot51

@jackpot51
Copy link
Member

If you'd like to make a PR with the updated images, it would help.

@simonask
Copy link
Contributor Author

@jackpot51 Awesome, I did so in #367, let me know if anything else is needed. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants