From 1905d738066a296114b438be2c924f4121201a07 Mon Sep 17 00:00:00 2001 From: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com> Date: Sun, 12 Mar 2023 12:26:09 -0600 Subject: [PATCH] Fix release script's expected maintainers (#18477) The release process fails otherwise. Also improve the docs on how to approach documentation changes. --- build-support/bin/_release_helper.py | 2 +- docs/markdown/Contributions/releases/release-process.md | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/build-support/bin/_release_helper.py b/build-support/bin/_release_helper.py index 90d8acce4cf..15dce9edc0b 100644 --- a/build-support/bin/_release_helper.py +++ b/build-support/bin/_release_helper.py @@ -70,7 +70,7 @@ _expected_owners = {"benjyw", "John.Sirois", "stuhood"} -_expected_maintainers = {"EricArellano", "illicitonion", "wisechengyi"} +_expected_maintainers = {"EricArellano", "illicitonion", "wisechengyi", "kaos"} # Disable the Pants repository-internal internal_plugins.test_lockfile_fixtures plugin because diff --git a/docs/markdown/Contributions/releases/release-process.md b/docs/markdown/Contributions/releases/release-process.md index 8c7bfd7bd13..b1e9efae472 100644 --- a/docs/markdown/Contributions/releases/release-process.md +++ b/docs/markdown/Contributions/releases/release-process.md @@ -193,12 +193,10 @@ Note that this step can currently only be performed by a subset of maintainers d Go to the [documentation dashboard](https://dash.readme.com/). In the top left dropdown, where it says the current version, click "Manage versions". Click "Add new version" and use a "v" with the minor release number, e.g. "v2.9". Fork from the prior release. Mark this new version as public by clicking on "Is public?" -Also, update the [Changelog](doc:changelog) page with the new release series at the top of the table. It's okay if there are no "highlights" yet. - ### Sync the `docs/` content See the `docs/NOTES.md` for instructions setting up the the necessary Node tooling your first time. -You'll need to 1st login as outlined there via some variant of `npx rdme login --project pants ...`. +You'll need to 1st login as outlined there via some variant of `npx rdme login --2fa --project pants ...`. On the relevant release branch, run `npx rdme docs docs/markdown --version v.`; e.g: `npx rdme docs docs/markdown --version v2.8`. ### Regenerate the references