Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Sequenced Bookmarks and Batch Rendering #214

Closed
12 tasks done
RebeccaNowak opened this issue Jul 11, 2022 · 2 comments
Closed
12 tasks done

Improved Sequenced Bookmarks and Batch Rendering #214

RebeccaNowak opened this issue Jul 11, 2022 · 2 comments
Assignees
@RebeccaNowak

Comments

@RebeccaNowak
Copy link
Collaborator

RebeccaNowak commented Jul 11, 2022 •
edited
Loading

new Features:

  • anti-aliasing for batch rendering
  • save sequenced bookmark settings with scene - already implemented
  • replace obsolete animation system
    • loop functionality
  • save visibility and other surface/annotation attributes with bookmarks
    • update button for bookmarks
  • apply saved surface/annotation attributes during animation
    • save original settings to restore after end of animation
    • bug: surface disappears when using animation after PRo3D restart
  • use additional saved bookmark attributes for batch rendering

Bugs:

  • open output path in explorer for batch rendering
  • Coordinate system of rover poses appears differently in viewer and batch rendering [need to verify if fixed]
@RebeccaNowak RebeccaNowak self-assigned this Jul 11, 2022
RebeccaNowak added a commit that referenced this issue Jul 12, 2022
@RebeccaNowak
anti aliasing for batch rendering, added
9e4072f 
 checkbox for debug mode #214
RebeccaNowak added a commit that referenced this issue Jul 12, 2022
@RebeccaNowak
added JSON members for debug parameter
7321739 
 (Sequenced Bookmarks)  #214
RebeccaNowak added a commit that referenced this issue Jul 12, 2022
@RebeccaNowak
now opening right path when selecting batch
cb9883e 
rendering output path #214
RebeccaNowak added a commit that referenced this issue Jul 14, 2022
@RebeccaNowak
first test of new animation system; basics work,
59e7098 
still needs some debugging and a lot of additions #214
RebeccaNowak added a commit that referenced this issue Jul 14, 2022
@RebeccaNowak
replaced play/stop/next/prev button functionality
fdcd828 
with new animations #214
RebeccaNowak added a commit that referenced this issue Jul 15, 2022
@RebeccaNowak
fixed problem with animations not starting, fixed
fd4964a 
pause and resume functionality  #214
RebeccaNowak added a commit that referenced this issue Jul 15, 2022
@RebeccaNowak
basics for saving scene state with bookmarks,
44e6ac1 
basic animation for Bookmark type (WIP)  #214
RebeccaNowak added a commit that referenced this issue Jul 18, 2022
@RebeccaNowak
created SequencedBookmark model type for saving
af9d7e4 
scene state and animation settings; added settings
for global animation; serialisation #214
RebeccaNowak added a commit that referenced this issue Jul 19, 2022
@RebeccaNowak
now saving scene state with sequenced bookmarks,
55f25e1 
and applying it during animation. Needs testing
and settings GUI #214
RebeccaNowak added a commit that referenced this issue Jul 19, 2022
@RebeccaNowak
now restoring original scene state after
62f5898 
animation. Works, but there is a problem
when loading a scene that needs fixing #214
RebeccaNowak added a commit that referenced this issue Jul 20, 2022
@RebeccaNowak
fixed bug with disappearing surfaces and other
4fbab4e 
scene elements #214
RebeccaNowak added a commit that referenced this issue Jul 20, 2022
@RebeccaNowak
added looping modes #214
7718ae8
RebeccaNowak added a commit that referenced this issue Jul 25, 2022
@RebeccaNowak
allow applying bookmark scene state on select,
2b54a95 
allow updating scene state of bookmark,
allow choosing between normal and smooth path #214
RebeccaNowak added a commit that referenced this issue Jul 25, 2022
@RebeccaNowak
fixed fly to Bookmark, smooth path works,
2831386 
WIP on delay & duration for non-global animation #214
RebeccaNowak added a commit that referenced this issue Jul 25, 2022
@RebeccaNowak
duration for individual bookmarks now applied
7224c01 
correctly; WIP on delay #214
RebeccaNowak added a commit that referenced this issue Jul 25, 2022
@RebeccaNowak
delay now correctly applied #214
b6f6a38
RebeccaNowak added a commit that referenced this issue Jul 25, 2022
@RebeccaNowak
Fly to Bookmark now starts at current view,
7350194 
not selected bookmark, and uses easing if
selected in GUI #214
RebeccaNowak added a commit that referenced this issue Jul 25, 2022
@RebeccaNowak
added types for new bookmark batch rendering (WIP)
5082fbd 
added configurations to scene state #214
RebeccaNowak added a commit that referenced this issue Jul 26, 2022
@RebeccaNowak
snapshot animations with bookmarks work now
4955e3f 
major changes in Snapshot types to accomodate new functionality
but everything should be backward compatible
no changes to snapshot command line interface
needs more testing and some code clean-up #214
RebeccaNowak added a commit that referenced this issue Jul 28, 2022
@RebeccaNowak
bugfixes, now calculating fps of recorded
6021522 
animation #214
RebeccaNowak added a commit that referenced this issue Jul 28, 2022
@RebeccaNowak
bugfixes, half fps mode for bookmark
3e0690f 
batch rendering #214
RebeccaNowak added a commit that referenced this issue Jul 28, 2022
@RebeccaNowak
code clean-up #214
89e9972
RebeccaNowak added a commit that referenced this issue Jul 29, 2022
@RebeccaNowak
documentation #214
867e621
RebeccaNowak added a commit that referenced this issue Jul 29, 2022
@RebeccaNowak
updated release notes #214
c70b3cc
RebeccaNowak added a commit that referenced this issue Aug 9, 2022
@RebeccaNowak
Bugfixes for Sequenced Bookmarks #214
1cab10e
RebeccaNowak added a commit that referenced this issue Aug 10, 2022
@RebeccaNowak
replaced animation recording system for
49d6b6b 
batch rendering because of performance issues
WIP #214
RebeccaNowak added a commit that referenced this issue Aug 11, 2022
@RebeccaNowak
fixed scale bar bug, removed unused code #214
1dd6df5
RebeccaNowak added a commit that referenced this issue Aug 11, 2022
@RebeccaNowak
fixed frustum bug for batch rendering of
f84cb6f 
sequenced bookmarks; added traverses to scene state;
added scene state saving and restoring #214
@haraldsteinlechner
Copy link
Collaborator

haraldsteinlechner commented Dec 14, 2022 •
edited
Loading

@RebeccaNowak this seems done, could you please confirm and close the issue?

@RebeccaNowak
Copy link
Collaborator Author

Issue completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RebeccaNowak RebeccaNowak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haraldsteinlechner @RebeccaNowak