Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error_connection_closed to be confused with error_connect_closed #119

Closed
tisba opened this issue Jul 30, 2015 · 1 comment
Closed

error_connection_closed to be confused with error_connect_closed #119

tisba opened this issue Jul 30, 2015 · 1 comment

Comments

@tisba
Copy link
Collaborator

tisba commented Jul 30, 2015

I see both errors from time to time which is a bit confusing.

error_connection_closed: https://github.com/processone/tsung/blob/master/src/tsung/ts_client.erl#L844
error_connect_closed: https://github.com/processone/tsung/blob/master/src/tsung/ts_client.erl#L891

According to https://tsung.readthedocs.org/en/latest/errorslist.html#error-connect-errorname (and that's correct IMO), error_connect_ prefixed errors indicate an error while establishing a connection to the server. So, error_connect_closed is correct.

Whereas error_connection_closed is reported when the connection is closed while sending data to the server. In this case the connection is already established and it should be prefixed with error_send_ (https://tsung.readthedocs.org/en/latest/errorslist.html#error-send-errorname).

So I propose to rename error_connection_closed to error_send_connection_closed. I'm happy to provide a pull request.

@tisba tisba changed the title error_connection_closed should be error_connect_closed error_connection_closed to be confused with error_connect_closed Jul 30, 2015
@nniclausse
Copy link
Contributor

I'm ok with this

@tisba tisba added this to the 1.8.0 milestone Jul 24, 2018
@tisba tisba closed this as completed in 5f00f54 Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants