Skip to content

Commit 5b3cbbd

Browse files
authored
refactor(cli)!: simplify installDependencies to install all monorepo deps (bigcommerce#1440)
1 parent addf5e9 commit 5b3cbbd

File tree

3 files changed

+12
-18
lines changed

3 files changed

+12
-18
lines changed

.changeset/fair-lobsters-own.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@bigcommerce/create-catalyst": minor
3+
---
4+
5+
BREAKING: Refactor `installDependencies` so that it installs all dependencies found in the root package.json file of the monorepo

packages/create-catalyst/src/commands/create.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export const create = new Command('create')
135135

136136
console.log(`\nUsing ${chalk.bold(packageManager)}\n`);
137137

138-
await installDependencies(projectDir, packageManager);
138+
await installDependencies(projectDir);
139139

140140
console.log(
141141
[
@@ -239,7 +239,7 @@ export const create = new Command('create')
239239

240240
console.log(`\nUsing ${chalk.bold(packageManager)}\n`);
241241

242-
await installDependencies(projectDir, packageManager);
242+
await installDependencies(projectDir);
243243

244244
await spinner(exec(`${packageManager} run --prefix ${projectDir} generate`), {
245245
text: 'Creating GraphQL schema...',

packages/create-catalyst/src/utils/install-dependencies.ts

+5-16
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,14 @@
11
import chalk from 'chalk';
2-
import { addDependency, addDevDependency, installDependencies as installDeps } from 'nypm';
2+
import { installDependencies as installDeps } from 'nypm';
33

4-
import { type PackageManager } from './pm';
54
import { spinner } from './spinner';
65

7-
const installAllDeps = async (projectDir: string, packageManager: PackageManager) => {
8-
await installDeps({ cwd: projectDir, silent: true, packageManager });
9-
await addDependency('@bigcommerce/catalyst-client', {
10-
cwd: projectDir,
11-
silent: true,
12-
packageManager,
13-
});
14-
await addDevDependency('@bigcommerce/eslint-config-catalyst', {
15-
cwd: projectDir,
16-
silent: true,
17-
packageManager,
18-
});
6+
const installAllDeps = async (projectDir: string) => {
7+
await installDeps({ cwd: projectDir, silent: true, packageManager: 'pnpm' });
198
};
209

21-
export const installDependencies = async (projectDir: string, packageManager: PackageManager) =>
22-
spinner(installAllDeps(projectDir, packageManager), {
10+
export const installDependencies = async (projectDir: string) =>
11+
spinner(installAllDeps(projectDir), {
2312
text: `Installing dependencies. This could take a minute...`,
2413
successText: `Dependencies installed successfully`,
2514
failText: (err) => chalk.red(`Failed to install dependencies: ${err.message}`),

0 commit comments

Comments
 (0)