This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Add --verify_common_dir option to cargo-verify #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo-verify/src/seahorn.rs
Outdated
| let mut cmd = Command::new("sea"); | ||
| cmd.args(&["bpf", |
There was a problem hiding this comment.
Ah, this looks like what I was asking for in the other, separated commit!
Moving this content into an external file.
docker/seahorn/Dockerfile
Outdated
| ENV VERIFY_COMMON_DIR=/home/seahorn/verify-c-common | ||
|
|
||
| RUN git clone --no-checkout https://github.com/yvizel/verify-c-common.git ${VERIFY_COMMON_DIR} \ | ||
| RUN git clone --no-checkout https://github.com/seahorn/verify-c-common.git ${VERIFY_COMMON_DIR} \ | ||
| && cd ${VERIFY_COMMON_DIR} \ | ||
| && git checkout ${VERIFY_COMMON_VERSION} |
There was a problem hiding this comment.
Can you change the name of this environment variable to include the word "SEAHORN"?
Ditto for adding the command line argument to cargo-verify.
As it is, the directory does not look very "common" since it is SeaHorn specific and it's not obvious how we would generalize it for KLEE, SMACK, Crux or any other tool that we want to pass configuration files to.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.