Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated literal constraints #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NBNARADHYA
Copy link

@NBNARADHYA NBNARADHYA commented Feb 15, 2022

Signed-off-by: Nikhil B N [email protected]

Closes coral-xyz/anchor#901 (Prerequisite to this pr: coral-xyz/anchor#1441

Changes:

  1. Remove literal constraints: (#[account("...")] to #[account(constraint = ...)])

Signed-off-by: Nikhil B N <[email protected]>
@NBNARADHYA
Copy link
Author

@armaniferrante

@armaniferrante
Copy link
Contributor

This repo uses Anchor v0.4.4, which is before the constraint = keyword was added. This should fail to compile.

@NBNARADHYA
Copy link
Author

Contributor

@armaniferrante I was gonna ask. Should I change it to a specific version ?

@armaniferrante
Copy link
Contributor

Contributor

@armaniferrante I was gonna ask. Should I change it to a specific version ?

Nope since that would create an incompatible breaking chnage. The alternative would be to create a branch for the purpose of the anchor test.

@NBNARADHYA
Copy link
Author

Contributor

@armaniferrante I was gonna ask. Should I change it to a specific version ?

Nope since that would create an incompatible breaking chnage. The alternative would be to create a branch for the purpose of the anchor test.

@armaniferrante Sure! If you could create a branch for that, and mention the anchor version to bump it to:

I would:

  1. Make those changes here, and update this pr to merge to the new branch.
  2. Refer to this new branch(in submodule) in the code belonging to Remove depricated: literal constraints coral-xyz/anchor#1441.

Also, if the tests pass here: coral-xyz/anchor#1441 after making these modifications, should that pr merge to master or some new branch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated account constraints
3 participants