Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error "code"=>"beingFilled" #340

Open
cdmo opened this issue Jan 11, 2021 · 2 comments
Open

error "code"=>"beingFilled" #340

cdmo opened this issue Jan 11, 2021 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cdmo
Copy link
Contributor

cdmo commented Jan 11, 2021

Jan 11 10:00:36 L5bcapp02prod.vmhost.psu.edu sidekiq: 2021-01-11T15:00:36.698Z pid=27402 tid=otafegwq6 class=ChangePickupByDateJob jid=08156441fa320b3ee114f4a0 ERROR: pickup_by_date_3972070: {"messageList"=>[{"code"=>"beingFilled", "message"=>"The fillByDate for this request cannot be edited at this time because it is already in the process of being filled."}]}

https://app.datadoghq.com/apm/trace/4330986092317069574?spanID=2374386188483611811&env=production&sort=time&colorBy=service&spanViewType=metadata&graphType=flamegraph&shouldShowLegend=true

Error 400: [{"code"=>"beingFilled", "message"=>"The fillByDate for this request cannot be edited at this time because it is already in the process of being filled."}]

https://app.datadoghq.com/apm/trace/1794092664249146018?colorBy=service&env=production&graphType=flamegraph&shouldShowLegend=true&sort=desc&spanID=283198068775497228&spanViewType=metadata&timeHint=1631555464925.7979

@cdmo cdmo added the bug Something isn't working label Jan 11, 2021
@cdmo cdmo added this to the 1.0.x milestone Jan 11, 2021
@banukutlu banukutlu added the question Further information is requested label Jan 11, 2021
@cdmo
Copy link
Contributor Author

cdmo commented Jan 11, 2021

asked maryam about this earlier today, will see if she has any feedback. know she is busy with meetings

@banukutlu
Copy link
Contributor

banukutlu commented Jan 29, 2021

Sirsi's response :

The pickup date for a hold is ONLY generated once the item is trapped to fill the hold. User should not be able to extend that, as it prevents other users from being able to fill their holds on the same item

Asking Sirsi if there a way to determine if a hold is beingFilled before attempting to change the fillByDate? Some field on a hold that indicated this.

@banukutlu banukutlu reopened this Feb 12, 2021
@banukutlu banukutlu removed this from the 1.0.x milestone Mar 11, 2021
@banukutlu banukutlu added on hold and removed question Further information is requested on hold labels Mar 11, 2021
@banukutlu banukutlu added this to the 1.0.x milestone Mar 11, 2021
@banukutlu banukutlu self-assigned this Jun 9, 2021
@banukutlu banukutlu modified the milestones: 1.0.x, 1.1.x Jun 15, 2021
@banukutlu banukutlu modified the milestones: 1.1.x, 1.x.x May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants