From dc7b8ce56bf40b898d11c919bcf9459eb347d0e3 Mon Sep 17 00:00:00 2001 From: Vincent Tran Date: Fri, 12 Apr 2019 10:09:20 -0700 Subject: [PATCH] Fix the stale comment on ImpalaServer::RegisterQuery header Prior to this change, the comment from ImpalaServer::RegisterQuery asserts: "Registers the query exec state with client_request_state_map_ using the globally unique query_id and add the query id to session state's open query list." This comment is partially inaccurate about the current designs of this function since it does not add the query_id to the session state's open query list. Change-Id: If743e718f7322929acb710b36f85978dfbe981bf Reviewed-on: http://gerrit.cloudera.org:8080/13001 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins Reviewed-on: https://gerrit.sjc.cloudera.com/c/cdh/impala/+/49575 Reviewed-by: Laszlo Gaal Tested-by: Jenkins User CDH-Build: Laszlo Gaal Quasar-L0: Laszlo Gaal --- be/src/service/impala-server.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/be/src/service/impala-server.h b/be/src/service/impala-server.h index 6d4704c25c3..b5763233804 100644 --- a/be/src/service/impala-server.h +++ b/be/src/service/impala-server.h @@ -577,7 +577,7 @@ class ImpalaServer : public ImpalaServiceIf, std::shared_ptr* exec_state) WARN_UNUSED_RESULT; /// Registers the query exec state with client_request_state_map_ using the - /// globally unique query_id and add the query id to session state's open query list. + /// globally unique query_id. /// The caller must have checked out the session state. Status RegisterQuery(std::shared_ptr session_state, const std::shared_ptr& exec_state) WARN_UNUSED_RESULT;