Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing via pip broken by stargazer #565

Closed
apoorvalal opened this issue Jul 24, 2024 · 4 comments
Closed

installing via pip broken by stargazer #565

apoorvalal opened this issue Jul 24, 2024 · 4 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@apoorvalal
Copy link
Member

since stargazer is only listed as a dev dependency but is already used extensively in the package, installing from the repo produces this undesirable behaviour (pip install git+<url> installed in a fresh virtualenv)

image

proposals (mainly so that this error doesn't persist into next release on pypi)

  • make (py-econometrics/stargazer a default dependency)
  • drop it entirely
  • merge the existing PR against the main stargazer repo
@s3alfisc
Copy link
Member

Yes, thanks for the pointer Apoorva! We're still debating how to best integrate stargazer and pyfixest, and I think that at least for the next pypi release, it looks like it's swinging in the direction to both drop the stargazer dependency & delete the pf.Stargazer method from pyfixest's code base.

@s3alfisc s3alfisc added the dependencies Pull requests that update a dependency file label Jul 24, 2024
@apoorvalal
Copy link
Member Author

Yeah I think building something minimal and reasonable internally and exposing it via etable makes a lot more sense to me tbh; I think Stargazer packages end up in the same place 🙃.

@s3alfisc
Copy link
Member

Yup, maybe that's the best approach - to not directly depend on the stargazer package, to have a nice internal etable() function that does the most important things well (and is maybe a little prettier than the current solution), and additionally to make sure that stargazer supports pyfixest for users who want a lot of customization?

@apoorvalal
Copy link
Member Author

Yeah that makes sense; etable with reasonable aesthetics is the most a general regression package should promise to deliver IMO. Table customization is a rabbit-hole and promises to become scope-creep for this package. For sufficiently custom tables, there's no better alternative than to pipe numbers directly into text with fstrings f""" {coef} """ anyway (that's my preferred solution, but probably not the most beginner friendly 😆 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants