Skip to content

Commit 9621d21

Browse files
committed
AMDGPU: Report Arg's Value name in metadata if kernel_arg_name metadata is not available
Differential Revision: https://reviews.llvm.org/D40924 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@320176 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent fc1d511 commit 9621d21

5 files changed

+128
-63
lines changed

lib/Target/AMDGPU/MCTargetDesc/AMDGPUHSAMetadataStreamer.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,8 @@ void MetadataStreamer::emitKernelArg(const Argument &Arg) {
292292
Node = Func->getMetadata("kernel_arg_name");
293293
if (Node && ArgNo < Node->getNumOperands())
294294
Name = cast<MDString>(Node->getOperand(ArgNo))->getString();
295+
else if (Arg.hasName())
296+
Name = Arg.getName();
295297

296298
StringRef TypeName;
297299
Node = Func->getMetadata("kernel_arg_type");

test/CodeGen/AMDGPU/hsa-metadata-deduce-ro-arg.ll

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
; CHECK: - Name: test_ro_arg
44
; CHECK-NEXT: SymbolName: 'test_ro_arg@kd'
55
; CHECK-NEXT: Args:
6-
; CHECK-NEXT: - TypeName: 'float*'
6+
; CHECK-NEXT: - Name: in
7+
; CHECK-NEXT: TypeName: 'float*'
78
; CHECK-NEXT: Size: 8
89
; CHECK-NEXT: Align: 8
910
; CHECK-NEXT: ValueKind: GlobalBuffer
@@ -12,7 +13,8 @@
1213
; CHECK-NEXT: AccQual: ReadOnly
1314
; CHECK-NEXT: IsConst: true
1415
; CHECK-NEXT: IsRestrict: true
15-
; CHECK-NEXT: - TypeName: 'float*'
16+
; CHECK-NEXT: - Name: out
17+
; CHECK-NEXT: TypeName: 'float*'
1618
; CHECK-NEXT: Size: 8
1719
; CHECK-NEXT: Align: 8
1820
; CHECK-NEXT: ValueKind: GlobalBuffer

test/CodeGen/AMDGPU/hsa-metadata-enqueu-kernel.ll

+4-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
; CHECK-NEXT: Language: OpenCL C
1212
; CHECK-NEXT: LanguageVersion: [ 2, 0 ]
1313
; CHECK-NEXT: Args:
14-
; CHECK-NEXT: - TypeName: char
14+
; CHECK-NEXT: - Name: a
15+
; CHECK-NEXT: TypeName: char
1516
; CHECK-NEXT: Size: 1
1617
; CHECK-NEXT: Align: 1
1718
; CHECK-NEXT: ValueKind: ByValue
@@ -43,7 +44,8 @@ define amdgpu_kernel void @test_non_enqueue_kernel_caller(i8 %a)
4344
; CHECK-NEXT: Language: OpenCL C
4445
; CHECK-NEXT: LanguageVersion: [ 2, 0 ]
4546
; CHECK-NEXT: Args:
46-
; CHECK-NEXT: - TypeName: char
47+
; CHECK-NEXT: - Name: a
48+
; CHECK-NEXT: TypeName: char
4749
; CHECK-NEXT: Size: 1
4850
; CHECK-NEXT: Align: 1
4951
; CHECK-NEXT: ValueKind: ByValue

0 commit comments

Comments
 (0)