Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all license headers are BSD license (or compatible) #8418

Closed
mergennachin opened this issue Feb 12, 2025 · 7 comments · Fixed by #9275
Closed

Make sure all license headers are BSD license (or compatible) #8418

mergennachin opened this issue Feb 12, 2025 · 7 comments · Fixed by #9275
Labels
triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@mergennachin
Copy link
Contributor

  • Make sure all license headers are BSD license.
  • Make sure lint rules are in place for future such cases.
@mergennachin mergennachin added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 12, 2025
@mergennachin
Copy link
Contributor Author

@mergennachin
Copy link
Contributor Author

mergennachin commented Feb 12, 2025

Hi @mcremon-meta

Majority of these licenses are in cadence folder. https://gist.github.com/mergennachin/83bef4ab9bb5d721284ddb50168289d4

executorch repo is BSD license altogether, unless it is a third-party library.

A standard license header for individual files are something like this:

# Copyright (c) Meta Platforms, Inc. and affiliates.
# All rights reserved.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.

Can we codemod these files?

@mcremon-meta
Copy link
Contributor

Hi @mcremon-meta

Majority of these licenses are in cadence folder. https://gist.github.com/mergennachin/83bef4ab9bb5d721284ddb50168289d4

executorch repo is BSD license altogether, unless it is a third-party library.

A standard license header for individual files are something like this:

# Copyright (c) Meta Platforms, Inc. and affiliates.
# All rights reserved.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.

Can we codemod these files?

@mergennachin yup we can change that. @zonglinpeng can you take a look? If it's urgent and you don't have time, let me know and we'll find someone to do it quickly.

@mergennachin
Copy link
Contributor Author

@mcremon-meta

It's currently coming from our partners. In particular, during the IP review, their attorneys are raising this as potential legal risks when contributing to our repo. So, I'd say somewhat urgent.

In parallel, I will create OSS lintrunner rule to make sure it doesn't happen in the future.

@zonglinpeng
Copy link
Contributor

zonglinpeng commented Feb 12, 2025

@mergennachin Thanks for catching this - Will fix them now and target to ship by EOD if that works? Updating BSD license header was long on my TODO but good to know it's urgent :)
cc. @mcremon-meta
p.s. @mcremon-meta will be out in next 2 month. Please @ me directly for cadence subfolder issues

@mcremon-meta
Copy link
Contributor

#8420 should fix our side, let me know if I missed any!

@mergennachin
Copy link
Contributor Author

@digantdesai

remaining here: #8428

@mergennachin mergennachin changed the title Make sure all license headers are BSD license Make sure all license headers are BSD license (or compatible) Mar 14, 2025
mergennachin added a commit that referenced this issue Mar 18, 2025
We mistakenly include wrong headers to files. Let's catch them in
lintrunner.

Partially fixes #8418
@mergennachin mergennachin reopened this Mar 18, 2025
oscarandersson8218 pushed a commit to oscarandersson8218/executorch that referenced this issue Mar 21, 2025
We mistakenly include wrong headers to files. Let's catch them in
lintrunner.

Partially fixes pytorch#8418
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this issue Apr 2, 2025
We mistakenly include wrong headers to files. Let's catch them in
lintrunner.

Partially fixes pytorch#8418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants