-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure all license headers are BSD license (or compatible) #8418
Comments
Here are some examples: https://github.com/pytorch/executorch/blob/main/backends/cadence/aot/pass_utils.py#L1 |
Majority of these licenses are in cadence folder. https://gist.github.com/mergennachin/83bef4ab9bb5d721284ddb50168289d4 executorch repo is BSD license altogether, unless it is a third-party library. A standard license header for individual files are something like this:
Can we codemod these files? |
@mergennachin yup we can change that. @zonglinpeng can you take a look? If it's urgent and you don't have time, let me know and we'll find someone to do it quickly. |
It's currently coming from our partners. In particular, during the IP review, their attorneys are raising this as potential legal risks when contributing to our repo. So, I'd say somewhat urgent. In parallel, I will create OSS lintrunner rule to make sure it doesn't happen in the future. |
@mergennachin Thanks for catching this - Will fix them now and target to ship by EOD if that works? Updating BSD license header was long on my TODO but good to know it's urgent :) |
#8420 should fix our side, let me know if I missed any! |
remaining here: #8428 |
We mistakenly include wrong headers to files. Let's catch them in lintrunner. Partially fixes #8418
We mistakenly include wrong headers to files. Let's catch them in lintrunner. Partially fixes pytorch#8418
We mistakenly include wrong headers to files. Let's catch them in lintrunner. Partially fixes pytorch#8418
The text was updated successfully, but these errors were encountered: