AttributeError: 'numpy.float64' object has no attribute 'numerator'

[HSPK]

🐛 Describe the bug

When use write_video and pass a float fps value, this error occurs.

import torch
from torchvision.io import write_video

write_video("test.mp4", (torch.randn(16, 224, 224, 3) * 255).to(torch.uint8), fps=5.0)

Versions

OS: macOS 15.3.1 (arm64)
GCC version: Could not collect
Clang version: 16.0.0 (clang-1600.0.26.6)
CMake version: version 3.31.6
Libc version: N/A

Python version: 3.10.14 (main, Jul 31 2024, 19:44:58) [Clang 15.0.0 (clang-1500.3.9.4)] (64-bit runtime)
Python platform: macOS-15.3.1-arm64-arm-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Apple M1 Pro

Versions of relevant libraries:
[pip3] mypy==1.15.0
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.26.4
[pip3] torch==2.4.1
[conda] No relevant packages

[stephenm7777]

@HSPK is there any specific reason as to why this needs to be a floating number? Could we not change this to an integer and avoid the error?

[HSPK]

@HSPK is there any specific reason as to why this needs to be a floating number? Could we not change this to an integer and avoid the error?

Hi @stephenm7777, you are right. I use float value first time because the type annotation of fps is float. These is no problem with integer value, maybe we should raise a warning or something to inform the user we don't support float fps value for now.

[NicolasHug]

Closed in #8991