Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove UPLOAD_DATA_DIR from configuration example. #3461

Open
sjanssen2 opened this issue Mar 6, 2025 · 1 comment
Open

remove UPLOAD_DATA_DIR from configuration example. #3461

sjanssen2 opened this issue Mar 6, 2025 · 1 comment

Comments

@sjanssen2
Copy link
Contributor

I might miss something here, but from reading the code of

class ConfigurationManager(object):
I cannot spot where the field UPLOAD_DATA_DIR of the [main] section is ever used. Maybe you want to remove it?

# Download path files
UPLOAD_DATA_DIR = /home/runner/work/qiita/qiita/qiita_db/support_files/test_data/uploads/

also in the test

# Download path files
UPLOAD_DATA_DIR = /tmp/

@antgonza antgonza changed the title unused field in configuration file remove UPLOAD_DATA_DIR from configuration example. Mar 6, 2025
@antgonza
Copy link
Member

antgonza commented Mar 6, 2025

Hi @sjanssen2, you are 100% right, this is not used any longer (it was first introduced in 2014), then superseded by the mount definition via the database, and left behind by mistake. Thank you for catching this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants