Initial qiita_pet commit #31
Conversation
What do you mean by that? If they do not have internet, they cannot download this code... |
|
They may want to use it while not connected to the internet, e.g. look at results while on a plane. On Mar 9, 2014, at 9:58 AM, josenavas <[email protected]mailto:[email protected]> wrote: this may be installed on non-internet-connected computers What do you mean by that? If they do not have internet, they cannot download this code... — |
|
I see... I was thinking at installation time, but I saw that we are hosting jquery on other projects, so it won't be an issue here 😇 |
|
Yeah, jquery uses the MIT licence and the two other libraries are MIT and WTFPL so we are good to host all of it. |
| #runs task given, with the yield required to get returned value | ||
| #equivalent of callback/wait pairing from tornado.gen | ||
| yield Task(self.redis.subscribe, self.channel) | ||
| if not self.redis.subscribed: |
There was a problem hiding this comment.
Not sure about this but if not subscribed this shouldn't continue, right?
|
You need to add tests for your code. Also, add the names of the new packages to |
|
👍 to @antgonza's comment. Make sure you list the version and location from which you can download the file. Can you also change jQuery and other dependencies to be minified versions? Same thing with CSS files. I see in a couple places that you have both minified and non-minified versions of the libraries, please keep only one. Please also remove all the:
|
|
Sounds good. I'm more inclined to leave the non-minified version of multiselect for now since there is still some development going on with it. Also, why isn't .DS_Store in .gitignore? |
|
Ok, do you think this will be changing in a near future? |
|
Yeah, there is some functionality I added in that may need to have it's implementation tweaked. We can discuss it more at the qiita meeting Tuesday. |
|
Did you have a chance to submit the pull request to upstream? |
|
Closing because going in new direction with page layout and interfacing. |
A lot of this is from jquery, which I added here since this may be installed on non-internet-connected computers. You can safely ignore what is in static. The rest should be my code.