Bug: If xclip is installed on Wayland uniclip prints errors and does not copy to clipboard

[DylanDonkersgoed]

Description of the bug

Uniclip prints errors and does not add anything to the clipboard when running in Wayland with xclip (or presumably xsel) installed. I believe this is happening because uniclip uses the first binary it finds here and xclip is prioritized over wl-paste:

https://github.com/quackduck/uniclip/blob/master/uniclip.go#L340

I don't think I actually need xclip so I was able to work around the issue by just uninstalling it. But it might be nice if uniclip was able to handle this somehow or at least provide a more informative warning to explain what's going on.

Verbose output (Use the --debug option)

Run `uniclip 192.168.99.143:42165` to join this clipboard

Connected to device at 192.168.99.155:57625
error: [exit status 1]
verbose: [sent: An error occurred wile getting the local clipboard]
error: [exit status 1]
error: [exit status 1]
error: [exit status 1]

Steps to Reproduce

1. Install uniclip on two machines, with one machine running Sway (I expect other Wayland environments are also affected but haven't tested it) and having xclip installed
2. Start uniclip as usual by running uniclip on the Wayland machine than uniclip <ip address> on the other
3. You will start seeing error messages similar to the ones above on the Wayland machine as soon as the two are connected

Expected behavior

Uniclip should run without errors in Wayland and share the clipboard between machines as normal. Or perhaps print a warning that there are multiple possible clipboard sources so it's clearer what was going on.

OS and Uniclip version

On the Wayland machine I was running the dev version of uniclip cloned from this GitHub on ArchLinux.

The other machine was Windows 10 running uniclip 2.3.6.

[g-h-97]

Similar issue here. Even after uninstalling xclip (under wayland) the following error showsup

Connected to the clipboard
error: [sorry, uniclip won't work if you don't have xsel, xclip, wayland or Termux installed :(
you can create an issue at https://github.com/quackduck/uniclip/issues]

[Kelerion-UK]

Same here.. cloned for github on both linux (gnome 46 wayland on 24.04) xclip installed or not.. get this on server:

craig@aragorn:~$ uniclip -d -p 6666
Starting a new clipboard
Run uniclip 192.168.0.236:6666 to join this clipboard

Connected to device at 192.168.0.208:46988
verbose: [sent: ]
verbose: [rcvd: An error occurred wile getting the local clipboard]
verbose: [sent: An error occurred wile getting the local clipboard]
verbose: [sent: craig@frodo:~$ uniclip -d 192.168.0.236:6666 <-- current content of clipboard when client connects
Connected to the clipboard
error: [exit status 1]
verbose: [sent: An error occurred wile getting the local clipboard]
error: [exit status 1]
error: [exit status 1]
verbose: [rcvd: ]
error: [exit status 1]
verbose: [rcvd: An error occurred wile getting the local clipboard]
error: [exit status 1]]

And this one client:

raig@frodo:~$ uniclip -d 192.168.0.236:6666
Connected to the clipboard
error: [exit status 1]
verbose: [sent: An error occurred wile getting the local clipboard]
error: [exit status 1]
error: [exit status 1]
verbose: [rcvd: ]
error: [exit status 1]
verbose: [rcvd: An error occurred wile getting the local clipboard]
error: [exit status 1]

[wwxiaoqi]

Similar issue here. Even after uninstalling xclip (under wayland) the following error showsup

Connected to the clipboard
error: [sorry, uniclip won't work if you don't have xsel, xclip, wayland or Termux installed :(
you can create an issue at https://github.com/quackduck/uniclip/issues]

Same here..
Whether xclip is installed or not.