Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create grants DAO -> Fix image upload flow #111

Closed
krati-creatoros opened this issue Mar 4, 2022 · 4 comments · Fixed by #158
Closed

create grants DAO -> Fix image upload flow #111

krati-creatoros opened this issue Mar 4, 2022 · 4 comments · Fixed by #158
Assignees
@AlwaysHungrie @richikchanda1999
Labels
bug Something isn't working design priority
Milestone
fix immediately

Comments

@krati-creatoros
Copy link

To Reproduce
Create a grants DAO. Upload a logo image.

  1. Firstly a loader should be shown
  2. When image upload fails, the error shown is "Transaction Failed"

Screenshot 2022-03-04 at 12 58 02 PM
@krati-creatoros krati-creatoros added the bug Something isn't working label Mar 4, 2022
@gyan0890
Copy link

gyan0890 commented Mar 4, 2022

Error message missing while creating a DAO: Image is mandatory.
If I don’t upload the image, it doesn’t move forward.

@AlwaysHungrie AlwaysHungrie added this to the fix immediately milestone Mar 7, 2022
@AlwaysHungrie AlwaysHungrie self-assigned this Mar 7, 2022
@richikchanda1999
Copy link
Contributor

@ankitnairr Need to know how to display mandatory and optional fields

@roohchillsharma
Copy link

@ankitnairr

@roohchillsharma
Copy link

  1. One static image as a placeholder @ankitnairr
  2. Image uploading will be optional

@richikchanda1999 richikchanda1999 mentioned this issue Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlwaysHungrie AlwaysHungrie

@richikchanda1999 richikchanda1999

Labels
bug Something isn't working design priority
Projects
None yet
Milestone
fix immediately
Development

Successfully merging a pull request may close this issue.

Default dummy image added - Need to change IPFS Hash only questbook/grants-frontend
5 participants
@AlwaysHungrie @richikchanda1999 @gyan0890 @roohchillsharma @krati-creatoros