-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[setup-r]: better document 'r-version' parameter #936
Conversation
Thanks! It definitely makes sense to document this better. We can cite the API, I think. Maybe we could link to https://api.r-hub.io/rversions/#/paths/~1resolve~1:version~1:os~1:arch/get which explicitly lists the possibilities? |
Although here, in actions more formats are allowed AFAIR. You can probably also write |
Is there a big benefit to that flexibility, or it's just for back-compatibility? |
This URL feels fragile? |
Oh, I see, |
Closes #935. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, great improvement
@jeroen Thanks! |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
Related to #935 -- is this helpful? Or guilty of exposing implementation details we'd rather not?
ref:
actions/setup-r/src/installer.ts
Line 734 in 3f55ea1
(PS didn't compile this to the README yet)