Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-r action: Document missing 'cran' input #942

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

agjendem
Copy link
Contributor

@agjendem agjendem commented Nov 7, 2024

Defining the cran input currently gives a warning when running the setup-r action, but it is actually read at https://github.com/r-lib/actions/blob/v2-branch/setup-r/src/installer.ts#L658

@gaborcsardi
Copy link
Member

Thanks! Can you please also document it in setup-r/README.Rmd? Thanks again!

@agjendem agjendem force-pushed the add-missing-cran-input branch from 7e6ca31 to cf0f8ea Compare November 7, 2024 10:51
@agjendem
Copy link
Contributor Author

agjendem commented Nov 7, 2024

Thanks! Can you please also document it in setup-r/README.Rmd? Thanks again!

I've given it a shot, I'm not familiar with the tools used here, so I wasn't able to wrangle glue_data() into not rendering the default-value part for a given row.

@gaborcsardi
Copy link
Member

Thank you!

@gaborcsardi gaborcsardi merged commit 4330148 into r-lib:v2-branch Nov 8, 2024
26 checks passed
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants