Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

will anything be ever done about colinear edges restriction #8

Open
makc opened this issue Mar 13, 2017 · 6 comments
Open

will anything be ever done about colinear edges restriction #8

makc opened this issue Mar 13, 2017 · 6 comments
Assignees
Labels

Comments

@makc
Copy link

makc commented Mar 13, 2017

I mean, now I have to wiggle the vertices by 1e-something * Math.random () which I should not have to. Just have divisions by 0 replaced by some small number, and it should work.

@r3mi
Copy link
Owner

r3mi commented Mar 19, 2017

This is an issue that is present in the original algorithm, from the C++ version (now here : https://github.com/greenm01/poly2tri ).
You are suggesting ignoring COLLINEAR detection, and ignoring potential math error resulting from it ? Maybe it could work.
Are you able to suggest a patch ?
If not, I may have a look latter.

@r3mi r3mi self-assigned this Mar 20, 2017
@r3mi r3mi added the bug label Mar 20, 2017
@makc
Copy link
Author

makc commented Mar 21, 2017

Are you able to suggest a patch ?

I am not an expert here. What I can say is that this hack allows this test to pass:

screen shot 2017-03-21 at 10 40 58

@makc
Copy link
Author

makc commented Mar 21, 2017

other tests like big roundish triangle and butterfly-like polygon fail, so the hack is no good.

@joel-simon
Copy link

Any update here?

@r3mi
Copy link
Owner

r3mi commented Nov 25, 2018

Sorry, not for the time being.

@obidobi
Copy link
Contributor

obidobi commented Jan 11, 2019

What is the issue, putting steiner points on the polygon edge should split the edge?

Steiner points are supposed to be placed inside the polygon. I guess you will have to refine your polygon edges before sending it to the triangulator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants