From 32e554e68195b48d462d5ef96defbb1e64679eae Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Fri, 6 Mar 2020 12:45:15 +0100 Subject: [PATCH] Remove "could not get checksum with tar-split" debug message This code was originally written for v1.10 migration where it signified that layers were recomputed from pre 1.8 layout and could possibly change the tarball checksums. It's now being repurposed in the BuildKit adapter but there it doesn't have any warn condition as all data generated by builder is new anyway. Currently, debug log entries as the one below may appear in the daemon logs: [2019-10-02T10:00:06.690674253Z] could not get checksum for "x128nsj79yzfx4j5h6em2w2on" with tar-split: "no tar-split file" This patch removes the debug log, as it may confuse users ("we couldn't validate what we downloaded, but we're gonna run it anyway?") Signed-off-by: Sebastiaan van Stijn --- layer/migration.go | 1 - 1 file changed, 1 deletion(-) diff --git a/layer/migration.go b/layer/migration.go index 5834659433e61..80f0ff7ff4677 100644 --- a/layer/migration.go +++ b/layer/migration.go @@ -15,7 +15,6 @@ import ( func (ls *layerStore) ChecksumForGraphID(id, parent, oldTarDataPath, newTarDataPath string) (diffID DiffID, size int64, err error) { defer func() { if err != nil { - logrus.Debugf("could not get checksum for %q with tar-split: %q", id, err) diffID, size, err = ls.checksumForGraphIDNoTarsplit(id, parent, newTarDataPath) } }()