This changes the role-attribute in BulkyLinks for Menu-Items (ILIAS-eLearning#3737)

Fix for: https://mantis.ilias.de/view.php?id=31552

Author: swiniker

src/UI/templates/default/Link/tpl.bulky.html

@@ -1 +1 @@
-<a class="il-link link-bulky" href="{HREF}" <!-- BEGIN open_in_new_viewport --> target="_blank" rel="noopener"<!-- END open_in_new_viewport --><!-- BEGIN with_id --> id="{ID}"<!-- END with_id --> <!-- BEGIN with_aria_role --> aria-role="{ARIA_ROLE}"<!-- END with_aria_role --> >{SYMBOL}<span class="bulky-label">{LABEL}</span></a>
+<a class="il-link link-bulky" href="{HREF}" <!-- BEGIN open_in_new_viewport --> target="_blank" rel="noopener"<!-- END open_in_new_viewport --><!-- BEGIN with_id --> id="{ID}"<!-- END with_id --> <!-- BEGIN with_aria_role --> role="{ARIA_ROLE}"<!-- END with_aria_role --> >{SYMBOL}<span class="bulky-label">{LABEL}</span></a>

tests/UI/Component/Link/BulkyLinkTest.php

@@ -38,6 +38,28 @@ public function testWrongConstruction()
         $this->expectException(\TypeError::class);
         $link = $this->factory->bulky('wrong param', "label", $this->target);
     }
+    
+    public function testWithAriaRole()
+    {
+        try {
+            $b = $this->factory->bulky($this->glyph, "label", $this->target)
+            ->withAriaRole(I\Button\Bulky::MENUITEM);
+            $this->assertEquals("menuitem", $b->getAriaRole());
+        } catch (\InvalidArgumentException $e) {
+            $this->assertFalse("This should not happen");
+        }
+    }
+    
+    public function testWithAriaRoleIncorrect()
+    {
+        try {
+            $this->factory->bulky($this->glyph, "label", $this->target)
+            ->withAriaRole("loremipsum");
+            $this->assertFalse("This should not happen");
+        } catch (\InvalidArgumentException $e) {
+            $this->assertTrue(true);
+        }
+    }
 
     public function testGetLabell()
     {
@@ -129,4 +151,22 @@ public function testRenderingWithId()
             $r->render($b)
         );
     }
+        
+    public function testRenderWithAriaRoleMenuitem()
+    {
+        $r = $this->getDefaultRenderer();
+        $b = $this->factory->bulky($this->icon, "label", $this->target)
+        ->withAriaRole(I\Button\Bulky::MENUITEM);
+        
+        $expected = ''
+        . '<a class="il-link link-bulky" href="http://www.ilias.de" role="menuitem">'
+        . '<img class="icon someExample small" src="./templates/default/images/icon_default.svg" alt="Example"/>'
+        . ' <span class="bulky-label">label</span>'
+        . '</a>';
+                        
+        $this->assertHTMLEquals(
+            $expected,
+            $r->render($b)
+        );
+    }
 }