Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace changes in React\Promise v3.x #159

Open
whoisninjaturtle opened this issue Dec 3, 2024 · 1 comment
Open

Namespace changes in React\Promise v3.x #159

whoisninjaturtle opened this issue Dec 3, 2024 · 1 comment

Comments

@whoisninjaturtle
Copy link

whoisninjaturtle commented Dec 3, 2024

React\Promise reorganized their project structure in version 3, such that the RejectedPromise class once located in the React\Promise namespace is now located in React\Promise\Internal instead.

This causes a missing class inside Ratchet\Pawl\Connector which still attempts to import it from the React\Promise namespace.

The composer.json dependency for React\Promise is created by React\Socket which requires ^3.2 || ^2.6 || ^1.2.1 but neither React\Socket nor Ratchet\Pawl specify a major version below 3, meaning the default dependencies lead you into this situation.

In either case, it seems to go hand in hand; the namespace can neither be adjusted nor left alone without revisiting those dependencies in one direction or the other.

orioljd added a commit to orioljd/Pawl that referenced this issue Dec 11, 2024
@clue
Copy link
Member

clue commented Dec 11, 2024

The RejectedPromise class should not be used explicitly and should be replaced with a reject() function call instead, see reactphp/promise#155 / reactphp/promise#164 / reactphp/promise#165.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants