Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uvicorn for running Flask #1055

Closed
Archmonger opened this issue Jun 15, 2023 · 1 comment
Closed

Use uvicorn for running Flask #1055

Archmonger opened this issue Jun 15, 2023 · 1 comment
Labels
flag-blocked Currently cannot be resolved. priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Jun 15, 2023 •
edited
Loading

Current Situation

We currently do not use uvicorn for running flask due to flask-sock's incompatibility with WsgiToAsgi middleware.

Proposed Actions

When/if WsgiToAsgi middleware gets compatibility with flask-sock, we should migrate our flask backend to use uvicorn

Blocked on miguelgrinberg/flask-sock#58
@Archmonger Archmonger added priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior flag-blocked Currently cannot be resolved. labels Jun 15, 2023
@Archmonger
Copy link
Contributor Author

Archmonger commented Jun 15, 2023 •
edited
Loading

WsgiToAsgi isn't really fully fleshed out, so we really should avoid using it. Unless Flask adds native ASGI support, uvicron compatibility becomes unreasonable to develop.

@Archmonger Archmonger closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag-blocked Currently cannot be resolved. priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Archmonger