Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] French Localization #31

Closed
mooms06 opened this issue Oct 14, 2024 · 6 comments
Closed

[Feature] French Localization #31

mooms06 opened this issue Oct 14, 2024 · 6 comments

Comments

@mooms06
Copy link

mooms06 commented Oct 14, 2024

Thank you for this app, and thanks for updating it for .Net 8.

Can you make the application translatable ?

I've made a mock-up for a French version:

2024-10-14 12_50_06-Ideapad Toolkit-fr 2024-10-14 12_49_40-Ideapad Toolkit

Please note that the UAC shield icon is misplaced in the original version, it should be shifted to the right.

2024-10-14 12_50_06-Ideapad Toolkit
@mooms06
Copy link
Author

mooms06 commented Oct 14, 2024

I've made a fork with nearly all the changes I wanted.
I was even able to make a release, thanks to you.

https://github.com/mooms06/IdeapadToolkit/releases

@mooms06
Copy link
Author

mooms06 commented Oct 14, 2024

Some captures:

UlogY6N

hs39vwE

0NDoT4I

@reagcz
Copy link
Owner

reagcz commented Oct 14, 2024

I've added proper localization in the newest update. I used the translations from your fork. Thanks. Don't forget to restart the app after changing the language.

@reagcz reagcz closed this as completed Oct 14, 2024
@mooms06
Copy link
Author

mooms06 commented Oct 14, 2024

That was quick, thanks !

One little mistake: Home should be translated to Accueil and not Maison.

@reagcz
Copy link
Owner

reagcz commented Oct 14, 2024

I've fixed it and recreated the release

@mooms06
Copy link
Author

mooms06 commented Oct 14, 2024

That's perfect, thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants