Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowerType #50

Closed
zedomel opened this issue Dec 7, 2020 · 14 comments
Closed

flowerType #50

zedomel opened this issue Dec 7, 2020 · 14 comments

Comments

@zedomel
Copy link
Contributor

zedomel commented Dec 7, 2020

Field Value
GUID
Rebipp Class rebipp:PlantTrait
Label flowerType
Definition The type of flower describing whether the flower's corolla opens or not, exposing its reproductive parts to floral visitors (cleistogamous, chasmogamous or mixed).
Comments Recommended best practice is to use a controlled vocabulary. Example: Plant Trait Ontology
Examples cleistogamous, chasmogamous, http://purl.obolibrary.org/obo/TO_0000882
Controlled vocabulary Plant Trait Ontology
Darwin Core Class Occurrence
Cardinality One to one
Reference Protocol
@zedomel
Copy link
Contributor Author

zedomel commented Dec 7, 2020

Change term definition to:
The type of flower describing whether the flower's corolla opens or not, exposing its reproductive parts to floral visitors.

@fonturbel
Copy link

I am confused by the controlled vocabulary options...

@zedomel
Copy link
Contributor Author

zedomel commented Jan 12, 2021

@fonturbel could you share your thoughts with us? What is confused? The ontology term: http://purl.obolibrary.org/obo/TO_0000882 ?

@viniciusduartina
Copy link

Agree with definiton and vocabulary. Please, include mixed as an option in the controled vocabulary.

@pietrokiyoshi
Copy link

Ok with me regarding the terms.

@joiceiamara
Copy link

Nothing to add

@carmensspires
Copy link

Nothing to add.

@arech2003
Copy link

Nothin to add and agree with @zedomel

@carmensspires
Copy link

Nothing to add

@cepnunes
Copy link

cepnunes commented Jan 25, 2021

I believe the name of the trait could be improved here as "flowerType" can be interpreted as other concepts. I suggest changing the name to "flowerOpening" or "flowerOpeningType" to be more specific to the user. Moreover, I agree with adding the "mixed cleistogamous and chasmogamous" option to the controlled vocabulary.

@Mardiore
Copy link

I agree with @cepnunes "flowerType can be interpreted as other concepts" (e.g. corolla type) and I agree with @viniciusduartina.

@anselmoeco
Copy link

The point raised by @cepnunes is important to be considered.

@paf1306
Copy link

paf1306 commented Mar 2, 2021

Nothing else to add.

@zedomel
Copy link
Contributor Author

zedomel commented Mar 11, 2021

New label: flowerOpeningType
New definition: The type of flower describing whether the flower's corolla opens or not, exposing its reproductive parts

@zedomel zedomel closed this as completed Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests