Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magefan succeeded to add their own entry #22

Closed
thomas-kl1 opened this issue Sep 27, 2021 · 4 comments
Closed

Magefan succeeded to add their own entry #22

thomas-kl1 opened this issue Sep 27, 2021 · 4 comments

Comments

@thomas-kl1
Copy link
Contributor

Screenshot from 2021-09-27 14-54-33

@thomas-kl1
Copy link
Contributor Author

I'll work on it later :) unless you already have a fix

@rav-redchamps
Copy link
Collaborator

Hey @thomas-kl1

Thanks for reporting this.

Possibly they add this menu item via plugin or observer instead of menu.xml.

In case you didn’t get a chance to look at this, I will be fixing this by tomorrow.

@rav-redchamps
Copy link
Collaborator

Just pushed a fix 2e6abb4 not sure if it's optimal.

Please give it a look and see if you can suggest changes.

@thomas-kl1
Copy link
Contributor Author

thanks @rav-redchamps for the fix! Nice to see it will also prevents any third party vendors to add menu entry with this method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants