-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export float conversion routines (or convert exported data into go types) #3206
Comments
Can I take this up @ndyakov ? |
Sure, if you need any guidance let me know.
…On Mon, 31 Mar 2025 at 10:47, Anurag Bandyopadhyay ***@***.***> wrote:
Can I take this up @ndyakov <https://github.com/ndyakov> ?
—
Reply to this email directly, view it on GitHub
<#3206 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALZXMWV2IP72GD3TIEUZUD2XDXJ5AVCNFSM6AAAAABTNDGTB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRVGM4TMNBTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: SoulPancake]*SoulPancake* left a comment (redis/go-redis#3206)
<#3206 (comment)>
Can I take this up @ndyakov <https://github.com/ndyakov> ?
—
Reply to this email directly, view it on GitHub
<#3206 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALZXMWV2IP72GD3TIEUZUD2XDXJ5AVCNFSM6AAAAABTNDGTB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRVGM4TMNBTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@SoulPancake yes, I assume we can create a second exported package utils and have a function that will execute the internal function. But just that, no need to export the whole utils package that is currently placed in |
@ndyakov However that would also require us to export the function so that we can call the internal function |
very important value
__score
inFT.SEARCH
is returned as raw string not converted. users need manually convert it to floatnow, this is internal redis type.
and redis go pkg does not export functions to convert it. which is bad and error prone and leads to wrong re-implementations.
Expected Behavior
Either:
Current Behavior
Possible Solution
export this https://github.com/redis/go-redis/blob/master/internal/proto/reader.go#L192
Steps to Reproduce
FT.SEARCH
__score
field in GoContext (Environment)
FT.SEARCH
is very important.__score
is very important.and this is not even proper float... what....
INFO
go.mod
Detailed Description
Possible Implementation
The text was updated successfully, but these errors were encountered: