Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SETNX: Examples about locking contain a deprecated command (GETSET) #2130

Open
cdelacruzpinto opened this issue Sep 18, 2022 · 1 comment
Open

Comments

@cdelacruzpinto
Copy link

cdelacruzpinto commented Sep 18, 2022

  • The example about simple locking uses GETSET, which is supposed to be deprecated.
  • According to the GETSET doc page, it can be replaced with "SET with the GET argument when migrating or writing new code". Maybe update the SETNX doc to do it this way if it's backwards compatible?
@itamarhaber
Copy link
Member

Hi @cdelacruzpinto

Thanks for noting and reporting - you are very correct, and I think the that right resolution at this stage is to include both the current approach (i.e. SET ... GET) as well as the deprecated GETSET (for older versions).

Would you care to make a PR that addresses this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants