Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to a maintained through? #39

Open
ljharb opened this issue Dec 19, 2023 · 4 comments · May be fixed by #40
Open

update to a maintained through? #39

ljharb opened this issue Dec 19, 2023 · 4 comments · May be fixed by #40

Comments

@ljharb
Copy link

ljharb commented Dec 19, 2023

Hi! You depend on through, an excellent package that unfortunately has not been maintained since 2018. I've forked it as https://npmjs.com/@ljharb/through so that I can maintain it (with @dominictarr's blessing), and am using it in https://npmjs.com/tape.

Would you be interested in a PR that switches this project to using my fork instead of the original? It's effectively identical, but it'd ensure any vulnerabilities will be addressed in the future.

@regular
Copy link
Owner

regular commented Dec 19, 2023

Oh, hi, thanks for taking care of these classic modules that I still find very relevant today! (I hope someone would take over maintenance of substack's trumpet ...). Just one question: if you have @dominictarr 's blessing, why not simply transfer ownership of the original through repo and module? Going through all dependents to ask to switch over to the scoped version must be tedious and adding one more tree to the forest of modules increases confusion and takes up everyone's time when being forced to research what flavor of through is the maintained one nowadays.

@ljharb
Copy link
Author

ljharb commented Dec 19, 2023

Because unfortunately he disclaimed ownership and no longer has access to them.

ljharb added a commit to ljharb/unbzip2-stream that referenced this issue Dec 22, 2023
@ljharb ljharb linked a pull request Dec 22, 2023 that will close this issue
@ljharb
Copy link
Author

ljharb commented Dec 22, 2023

Filed #40

@valadaptive
Copy link

Just to clarify: the codebases are (as far as I can tell) effectively identical at this time, except for the fact that through has 0 dependencies whereas @ljharb/through has 12 nested dependencies for the purpose of Node 0.4 support. You can decide for yourself whether the extra dependencies are worth the Node 0.4 support, but I think it is important to be transparent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants