Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching relationships implementation #13

Closed
ghost opened this issue Mar 1, 2019 · 2 comments
Closed

Fetching relationships implementation #13

ghost opened this issue Mar 1, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Mar 1, 2019

According to https://jsonapi.org/format/#fetching-relationships then patern to fetch a relationship is /<primary>/<primary_id>/relationships/<secondary> This implementation uses /<primary>/<primary_id>/<secondary>. That seems to be valid too. Could you make the relationships part of the request optional?
@ghost
Copy link
Author

ghost commented Mar 1, 2019

Misinterpretation from my side.
/<primary>/<primary_id>/relationships/<secondary> should only return the id and type.
/<primary>/<primary_id>/<secondary> should return the data

@ghost ghost closed this as completed Mar 1, 2019
@CodingItWrong
Copy link
Contributor

Thanks for posting what you figured out, I wasn't aware of that distinction either 👍

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CodingItWrong