Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-p genric,dropmon prints stack trace for every packet #415

Open
igsilya opened this issue Jul 16, 2024 · 2 comments
Open

-p genric,dropmon prints stack trace for every packet #415

igsilya opened this issue Jul 16, 2024 · 2 comments

Comments

@igsilya
Copy link

igsilya commented Jul 16, 2024

Not a big issue, but a naive assumption that generic + dropmon will trace every packet and print the stack trace for the dropped ones, but it ends up printing the trace for every packet.

@atenart
Copy link
Contributor

atenart commented Jul 17, 2024

The --stack flag, used in the dropmon profile, is global. Once it is set stack traces are retrieved for every probe. We don't currently have per-probe flags available so changing the logic is not possible ATM, even though that can be an improvement to consider.

@vlrpl
Copy link
Contributor

vlrpl commented Jul 17, 2024

I agree it can be an improvement to consider.
Given this:
https://github.com/retis-org/retis/blob/main/retis/src/core/probe/kernel/bpf/include/common.h#L29

Adding at least some filter-in logic should not be much of a change (if memory serves, at least that was the intention if this was needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants