Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine behavior when writeToParcel is already implemented. #26

Open
JakeWharton opened this issue Dec 27, 2015 · 2 comments
Open

Determine behavior when writeToParcel is already implemented. #26

JakeWharton opened this issue Dec 27, 2015 · 2 comments
Milestone

Comments

@JakeWharton
Copy link
Collaborator

What should the behavior be when writeToParcel is already implemented? Fail? No-op? Emit only the describeContents method (and then what happens if this is implemented too)?

@rharter
Copy link
Owner

rharter commented Dec 27, 2015

With standard AutoValue, anything you implement is not overridden so that your custom implementation is executed. I would expect this would apply to writeToParcel as well.

In the case of both having been implemented by the user, I guess we can change applicable() to return false, since no implementation is needed, assuming we have that information early enough.

@JakeWharton
Copy link
Collaborator Author

There's also the CREATOR to consider here which would also need to be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants