Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended_met with implicit exec_dir + system architecture #25

Open
odrans opened this issue Jul 31, 2018 · 1 comment
Open

Extended_met with implicit exec_dir + system architecture #25

odrans opened this issue Jul 31, 2018 · 1 comment

Comments

@odrans
Copy link

odrans commented Jul 31, 2018

Hi Rich,

first, thanks a lot for this great R interface to HYSPLIT, it's really useful! I've just noticed a very minor issue when using extended_met = TRUE together with an implicit exec_dir. This configuration return

Error in file(con, "r") : cannot open the connection

An easy fix would be to replace l.157 in hysplit_trajectory.R :

if (extended_met) {
setup_cfg <- readLines('SETUP.CFG')  
[...]
 }

by

if (extended_met) {
    setup_cfg <- readLines(paste0(exec_dir, "/", "SETUP.CFG"))
[...]
  }

Another small thing I've noticed concerns the system architecture. It's great that you provide amd64 and x86 HYSPLIT versions for Linux but it took me some time to realize it while struggling with the required libraries. It could be useful to indicate in the README that one should adapt this to their systems by editing the R code.

Thanks again for all the great work!

Cheers,
Odran

@rich-iannone
Copy link
Owner

The issue with the reading should be fixed now. And you’re right, a README improvement talking about the bundled executables should be done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants