From b55d4320439fe1c59dd88d81a5a946738817e3f5 Mon Sep 17 00:00:00 2001 From: Julien Cretin Date: Tue, 1 Dec 2020 15:39:51 +0100 Subject: [PATCH] Apply review comments --- src/ctap/storage.rs | 5 +++-- src/ctap/storage/key.rs | 3 +-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ctap/storage.rs b/src/ctap/storage.rs index 054d3c81..0f1c73fd 100644 --- a/src/ctap/storage.rs +++ b/src/ctap/storage.rs @@ -387,7 +387,8 @@ impl PersistentStore { Ok(self.store.insert(key::MIN_PIN_LENGTH, &[min_pin_length])?) } - /// Returns a list of RP IDs that used to check if reading the minimum PIN length is allowed. + /// Returns the list of RP IDs that are used to check if reading the minimum PIN length is + /// allowed. #[cfg(feature = "with_ctap2_1")] pub fn _min_pin_length_rp_ids(&self) -> Result, Ctap2StatusCode> { let rp_ids = self @@ -400,7 +401,7 @@ impl PersistentStore { Ok(rp_ids.unwrap_or(vec![])) } - /// Set a list of RP IDs that used to check if reading the minimum PIN length is allowed. + /// Sets the list of RP IDs that are used to check if reading the minimum PIN length is allowed. #[cfg(feature = "with_ctap2_1")] pub fn _set_min_pin_length_rp_ids( &mut self, diff --git a/src/ctap/storage/key.rs b/src/ctap/storage/key.rs index 3e86d8b9..e37e4704 100644 --- a/src/ctap/storage/key.rs +++ b/src/ctap/storage/key.rs @@ -104,8 +104,7 @@ make_partition! { /// The encryption and hmac keys. /// - /// This entry is always present. It is generated at startup if absent. This is not a persistent - /// key because its value should change after a CTAP reset. + /// This entry is always present. It is generated at startup if absent. MASTER_KEYS = 2046; /// The global signature counter.