Skip to content

Commit

Permalink
remove progressbar
Browse files Browse the repository at this point in the history
  • Loading branch information
mxyng committed Nov 17, 2023
1 parent 0813387 commit f91bb2f
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 1,455 deletions.
96 changes: 5 additions & 91 deletions cmd/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import (
"github.com/jmorganca/ollama/api"
"github.com/jmorganca/ollama/format"
"github.com/jmorganca/ollama/parser"
"github.com/jmorganca/ollama/progressbar"
"github.com/jmorganca/ollama/readline"
"github.com/jmorganca/ollama/server"
"github.com/jmorganca/ollama/version"
Expand All @@ -53,9 +52,6 @@ func CreateHandler(cmd *cobra.Command, args []string) error {
return err
}

spinner := NewSpinner("transferring context")
go spinner.Spin(100 * time.Millisecond)

commands, err := parser.Parse(bytes.NewReader(modelfile))
if err != nil {
return err
Expand Down Expand Up @@ -99,41 +95,16 @@ func CreateHandler(cmd *cobra.Command, args []string) error {
}
}

var currentDigest string
var bar *progressbar.ProgressBar

request := api.CreateRequest{Name: args[0], Path: filename, Modelfile: string(modelfile)}
fn := func(resp api.ProgressResponse) error {
if resp.Digest != currentDigest && resp.Digest != "" {
spinner.Stop()
currentDigest = resp.Digest
// pulling
bar = progressbar.DefaultBytes(
resp.Total,
resp.Status,
)
bar.Set64(resp.Completed)
} else if resp.Digest == currentDigest && resp.Digest != "" {
bar.Set64(resp.Completed)
} else {
currentDigest = ""
spinner.Stop()
spinner = NewSpinner(resp.Status)
go spinner.Spin(100 * time.Millisecond)
}

log.Printf("progress(%s): %s", resp.Digest, resp.Status)
return nil
}

if err := client.Create(context.Background(), &request, fn); err != nil {
return err
}

spinner.Stop()
if spinner.description != "success" {
return errors.New("unexpected end to create model")
}

return nil
}

Expand Down Expand Up @@ -170,37 +141,13 @@ func PushHandler(cmd *cobra.Command, args []string) error {
return err
}

var currentDigest string
var bar *progressbar.ProgressBar

request := api.PushRequest{Name: args[0], Insecure: insecure}
fn := func(resp api.ProgressResponse) error {
if resp.Digest != currentDigest && resp.Digest != "" {
currentDigest = resp.Digest
bar = progressbar.DefaultBytes(
resp.Total,
fmt.Sprintf("pushing %s...", resp.Digest[7:19]),
)

bar.Set64(resp.Completed)
} else if resp.Digest == currentDigest && resp.Digest != "" {
bar.Set64(resp.Completed)
} else {
currentDigest = ""
fmt.Println(resp.Status)
}
log.Printf("progress(%s): %s", resp.Digest, resp.Status)
return nil
}

if err := client.Push(context.Background(), &request, fn); err != nil {
return err
}

if bar != nil && !bar.IsFinished() {
return errors.New("unexpected end to push model")
}

return nil
return client.Push(context.Background(), &request, fn)
}

func ListHandler(cmd *cobra.Command, args []string) error {
Expand Down Expand Up @@ -359,38 +306,13 @@ func pull(model string, insecure bool) error {
return err
}

var currentDigest string
var bar *progressbar.ProgressBar

request := api.PullRequest{Name: model, Insecure: insecure}
fn := func(resp api.ProgressResponse) error {
if resp.Digest != currentDigest && resp.Digest != "" {
currentDigest = resp.Digest
bar = progressbar.DefaultBytes(
resp.Total,
fmt.Sprintf("pulling %s...", resp.Digest[7:19]),
)

bar.Set64(resp.Completed)
} else if resp.Digest == currentDigest && resp.Digest != "" {
bar.Set64(resp.Completed)
} else {
currentDigest = ""
fmt.Println(resp.Status)
}

log.Printf("progress(%s): %s", resp.Digest, resp.Status)
return nil
}

if err := client.Pull(context.Background(), &request, fn); err != nil {
return err
}

if bar != nil && !bar.IsFinished() {
return errors.New("unexpected end to pull model")
}

return nil
return client.Pull(context.Background(), &request, fn)
}

func RunGenerate(cmd *cobra.Command, args []string) error {
Expand Down Expand Up @@ -442,9 +364,6 @@ func generate(cmd *cobra.Command, model, prompt string, wordWrap bool, format st
return err
}

spinner := NewSpinner("")
go spinner.Spin(60 * time.Millisecond)

var latest api.GenerateResponse

generateContext, ok := cmd.Context().Value(generateContextKey("context")).([]int)
Expand Down Expand Up @@ -475,10 +394,6 @@ func generate(cmd *cobra.Command, model, prompt string, wordWrap bool, format st

request := api.GenerateRequest{Model: model, Prompt: prompt, Context: generateContext, Format: format}
fn := func(response api.GenerateResponse) error {
if !spinner.IsFinished() {
spinner.Finish()
}

latest = response

if wordWrap {
Expand Down Expand Up @@ -511,7 +426,6 @@ func generate(cmd *cobra.Command, model, prompt string, wordWrap bool, format st

if err := client.Generate(cancelCtx, &request, fn); err != nil {
if strings.Contains(err.Error(), "context canceled") && abort {
spinner.Finish()
return nil
}
return err
Expand Down
44 changes: 0 additions & 44 deletions cmd/spinner.go

This file was deleted.

21 changes: 0 additions & 21 deletions progressbar/LICENSE

This file was deleted.

121 changes: 0 additions & 121 deletions progressbar/README.md

This file was deleted.

Loading

0 comments on commit f91bb2f

Please sign in to comment.