From a559ec15956094549d7213a9db966bd26c69371d Mon Sep 17 00:00:00 2001 From: Oliver Koenig Date: Mon, 7 Oct 2024 14:22:05 -0700 Subject: [PATCH] ADLR/megatron-lm!2189 - tests: Fix ENV export --- tests/functional_tests/shell_test_utils/_run_training.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/functional_tests/shell_test_utils/_run_training.sh b/tests/functional_tests/shell_test_utils/_run_training.sh index 9266b4a108..12dd359c65 100644 --- a/tests/functional_tests/shell_test_utils/_run_training.sh +++ b/tests/functional_tests/shell_test_utils/_run_training.sh @@ -43,7 +43,7 @@ mv $TRAINING_PARAMS_PATH.tmp $TRAINING_PARAMS_PATH # Pull env vars to export ENV_VARS=$(yq '... comments="" | .ENV_VARS | to_entries | .[] | [.key + "=" + .value] | join(" ")' $TRAINING_PARAMS_PATH) -for ARGUMENT in $ENV_VARS; do +while IFS= read -r ARGUMENT; do KEY=$(echo $ARGUMENT | cut -f1 -d=) KEY_LENGTH=${#KEY} @@ -51,7 +51,7 @@ for ARGUMENT in $ENV_VARS; do export "$KEY"="$VALUE" echo "$KEY=$VALUE" -done +done <<< "$ENV_VARS" # Run before script SCRIPT=$(cat $TRAINING_PARAMS_PATH | yq '.BEFORE_SCRIPT')