node: Return traverse error as os.PathError #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ppknap @rjeczalik While you're dealing with the other PR, could you also have a look at this (then we can update our vendoring all in one ;) ). |
|
I must have missed notification on this one, thanks @imsodin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing nodes are already reported as
os.PathError. This does the same for the error returned when setting up a recursive watch with a non-recursive watcher, i.e. during traversing. The error string is the same as before, so user of this library wont notice the change. This allows to check the underlying error and which path causes the problem. An example of a use case is for Syncthing, where we want to notify the user when the error is due to hitting the inotify handler limit.