Migrating from an older version, how to solve "Found two visible definitions" error?

[dboots]

In our type definition we have a table with a relationship that previous had that relationship defined in the code as

      field :owner,
            resolver: Directory::Resolvers::MyResolver.with_config(cfg_options: { ... }),
            extras: [:path],
            connection: true

now that results in the error

Found two visible definitions for `MyType.owner`
...stack trace...

If I comment it out, it works and I get the owner with the value expected, an array of strings or objects depending which isnt terrible, but before it returned the totalCount and various other graphQL goodies. Is there a way to retain that totalCount? Should I be removing the connection or defining it differently?

[rmosolgo]

Hey, yes, I'm sure there'll be some way to make this keep working.

Is there somewhere in your application that's defining field :owner another way? (That is, when you delete the definition you shared here, what definition is being used instead?) Could you share that other definition?

Also, please let me know how that other definition relates to the one you shared above. Is it in the same file, or a different file? what's the relationship between the two files, if there are two?

[dboots]

It looks like it is referenced in the concerns directory in some form of setup for a root level query type.

{ attr: 'owner',
      multi_value: true,
      operational: false,
      value_type: 'x',
      object_type: 'y,
      enum_values: nil,
      grouping: 'owners' }

Not sure how specific this is to the implementation v. being relevant to the migration. Would something have changed that changed this behavior? Maybe I can bark up that tree.

[rmosolgo]

This definitely did change in GraphQL-Ruby along the way and this isn't an uncommon issue to encounter.

GraphQL-Ruby object types can get field definitions from several places: from the object type class itself, from superclasses, or from interface modules.

Previously, when any of those places had definitions for the same field, the one on the "nearest" ancestor was used by GraphQL-Ruby. But now, GraphQL-Ruby supports multiple definitions for the same field (same name), but only one field definition is allowed to be visible at a time.

So my guess is that your application was overriding one field definition with another. This won't work exactly anymore because GraphQL-Ruby doesn't interpret a second field definition as overriding anymore.

The best thing would be to find a way to avoid the first field :owner, ... call, the one that you don't want to be used at runtime, so that this object type doesn't have two definitions for field :owner anymore. But exactly where that definition is coming from ... that's somewhere in your app!