Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route labels taking too much space on mobile #132

Closed
roata opened this issue Sep 20, 2020 · 6 comments · Fixed by #134
Closed

Route labels taking too much space on mobile #132

roata opened this issue Sep 20, 2020 · 6 comments · Fixed by #134
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/ ux User experience, design, aesthetics

Comments

@roata
Copy link
Member

roata commented Sep 20, 2020

The introduction of #128 brought a minor inconvenience for mobile users - roughly 25% of the screen is now occupied by the list of selected routes.
image

This can be resolved by adding a "collapse" button that might look like this:
image

It will compress this widget into a more compact representation, which can be expanded back into its normal state:
image

This functionality can be retained for the regular, desktop version too. In other words, this doesn't have to be a "mobile only" feature.

@roata roata added enhancement New feature or request good first issue Good for newcomers ux User experience, design, aesthetics hacktoberfest https://hacktoberfest.digitalocean.com/ labels Sep 20, 2020
@viorelrj
Copy link

Hi. Is anybody on this issue now? Willing to try and make my first open-source contribution

@iamandrewluca
Copy link
Member

iamandrewluca commented Sep 24, 2020

Hi @viorelrj, don't think anyone started to work on this. You can take it. Thanks! 🚀

@viorelrj
Copy link

@iamandrewluca, upd: sorry, will actually have to pass this one.

@iamandrewluca
Copy link
Member

No problems. 🙂

@roata
Copy link
Member Author

roata commented Sep 27, 2020

@viorelrj, could you provide some more context? It would help us if we knew the rationale behind your decision, so we could adapt.

If the task is not clearly defined - we can make refine the description. Alternatively, if you just don't have the time - it is out of our control, but at least we know this is not because of obvious deficiencies in our requirements.

And just in case - if you're not confident you can implement this, we're here to provide mentoring. You can get guidance from top-notch engineers like Andrei, or from less bright [but still supportive] people like me.

@viorelrj
Copy link

viorelrj commented Sep 27, 2020

@roata , thanks for great reply! The reason is that it is only now that I noticed that this project might slightly be a subject of non-concurrency contract I signed at my current job, thus will have to stop the initiative. Thanks for understanding and offering to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/ ux User experience, design, aesthetics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants