Skip to content
This repository has been archived by the owner on Jan 7, 2019. It is now read-only.

SoftwareSpiMaster::acquire() is broken #357

Closed
rleh opened this issue May 17, 2018 · 1 comment · Fixed by #359
Closed

SoftwareSpiMaster::acquire() is broken #357

rleh opened this issue May 17, 2018 · 1 comment · Fixed by #359

Comments

@rleh
Copy link
Member

rleh commented May 17, 2018

Bugfix in modm:

[...]::acquire(void *ctx, ConfigurationHandler handler)
{
-	if (ctx == nullptr)
+	if (context == nullptr)

Code in xpcc:

xpcc::SoftwareSpiMaster<SCK, MOSI, MISO>::acquire(void *ctx, ConfigurationHandler handler)
{
if (ctx == nullptr)

This bug is fixed in modm-io/modm#16

@salkinium Do we want to this fix in xpcc or does that complicate your xpcc-to-modm forward merging after every release?

@salkinium
Copy link
Member

Yes, if it's simple things that do not

  • move files around, or
  • modify the template language inside platform/,

then it's fine. You can even have duplicate git commits, since I merge it with via content diff patch and not directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants