-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'matcher() and
match = should supersede
chooser() and
choices = `?
#263
Comments
affected functions would include:
In addition, |
That functionality was kind of evolving over time. I think it's fine that we experimented with it and I agree that |
…nstead of `choices` ropensci#263
I think I got all the instances of this. |
I propose deprecating
choices =
for all the functions that use it in favor ofmatch =
. I know I createdchoices =
and pushed for it, but I think I like the behavior ofmatch =
better now, and it would bring some consistency to the package.I feel a little bad for the confusion this would introduce (deprecating
first
in favor ofchoices
, now deprecatingchoices
in favor ofmatch
), but it seems worth it maybe.The text was updated successfully, but these errors were encountered: