Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with the installation path of the headers #31

Closed
domire8 opened this issue Jan 18, 2022 · 3 comments
Closed

Issue with the installation path of the headers #31

domire8 opened this issue Jan 18, 2022 · 3 comments

Comments

@domire8
Copy link

domire8 commented Jan 18, 2022 •
edited
Loading

There is an issue with the CMakeLists.txt on branch ros2 since PR #28. Line 23 should be

install(DIRECTORY include/ DESTINATION include)

instead of

install(DIRECTORY include/ DESTINATION include/angles)

because the latter results in the angles.h header being under include/angles/angles/angles.h instead of include/angles/angles.h, which breaks the build of a few packages on galactic (joint_trajectory_controller for instance).

Possibly also related to #30 .
@domire8
Copy link
Author

domire8 commented Jan 18, 2022 •
edited
Loading

Sorry, I did not see #29 . I would highly appreciate a galactic branch though, as suggested here

This was referenced Jan 18, 2022
Merged
Merged
@sloretz
Copy link
Contributor

sloretz commented Jan 18, 2022

I created foxy-devel and galactic-devel branches.

Release repo PR: ros2-gbp/angles-release#1
rosdistro PR: ros/rosdistro#31834

@sloretz
Copy link
Contributor

sloretz commented Jan 18, 2022

Rolling release now that #32 is merged:

ros/rosdistro#31841

@domire8 domire8 closed this as completed Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sloretz @domire8