Apply suggestions from code review

Co-Authored-By: gummif <[email protected]>
roversun · May 8, 2019 · 9a60ad3 · 9a60ad3
1 parent 3d4be81
commit 9a60ad3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/tests/socket.cpp b/tests/socket.cpp
@@ -48,7 +48,7 @@ TEST_CASE("socket swap", "[socket]")
 }
 TEST_CASE("rass", "[socket]")
 {
-zmq::context_t ctx;
+    zmq::context_t ctx;
     zmq::socket_t sock(ctx, zmq::socket_type::push);
     sock.bind("inproc://test");
     const std::string m = "Hello, world";

diff --git a/zmq.hpp b/zmq.hpp
@@ -280,7 +280,7 @@ class message_t
     }
 
 #if defined(ZMQ_BUILD_DRAFT_API) && defined(ZMQ_CPP11)
-    // this function is too greedy, must add
+    // TODO: this function is too greedy, must add
     // SFINAE for begin and end support.
     template<typename T>
     explicit message_t(const T &msg_) : message_t(std::begin(msg_), std::end(msg_))
@@ -654,7 +654,8 @@ enum class send_flags : int
 
 constexpr send_flags operator|(send_flags a, send_flags b) noexcept
 {
-    return static_cast<send_flags>(static_cast<int>(a) | static_cast<int>(b));
+    return static_cast<send_flags>(static_cast<std::underlying_type<send_flags>::type>(a)
+        | static_cast<<std::underlying_type<send_flags>::type>(b));
 }
 
 enum class recv_flags : int