-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how can we make it work well with a relative layout? #2
Comments
I did a further attempt: Instead of specify a fixed width, I passed on "parent" and a percentage as "width" and "height" to xTermWindow.
The reason might be that "parent" is a blessed layout object which cannot easily be cloned. If I comment out the "clone" call in line 46 of blessed-xterm.js, it just works as expected, responsive to screen resize events and font size changes. So the question becomes: What's the purpose of cloning the options, is it safe to remove this line? |
Had the same issue and commenting the clone call also fixed the problem for me. I'm using the Grid layout from blessed-contrib. |
I have the same issue. |
Are any of you using a fork w/ this clone rmeoved @novast @kamushadenes @bencao ? Is there a solution that doesn't require me to fork this @rse ? |
No. Finally, I found that blessed.log meet my requirement. @acidjazz |
Thanks for the good work! Recently I used blessed-xterm in my project, to draw a dashboard like following:
here're some information about the above layout:
The problem I noticed is that when I resize the terminal, or adjust font size, the xterm window will remain its initial size, which does not fit any more.
Any idea whether we can make it more "responsible" to layout changes?
Thank you!
The text was updated successfully, but these errors were encountered: