Skip to content

Commit f1d2a26

Browse files
ChristianKoenigAMDalexdeucher
authored andcommitted
drm/radeon: set VM base addr using the PFP v2
Seems to make VM flushes more stable on SI and CIK. v2: only use the PFP on the GFX ring on CIK Signed-off-by: Christian König <[email protected]> Cc: [email protected] Signed-off-by: Alex Deucher <[email protected]>
1 parent f069dc1 commit f1d2a26

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

drivers/gpu/drm/radeon/cik.c

+3-2
Original file line numberDiff line numberDiff line change
@@ -5942,12 +5942,13 @@ static void cik_vm_decode_fault(struct radeon_device *rdev,
59425942
void cik_vm_flush(struct radeon_device *rdev, int ridx, struct radeon_vm *vm)
59435943
{
59445944
struct radeon_ring *ring = &rdev->ring[ridx];
5945+
int usepfp = (ridx == RADEON_RING_TYPE_GFX_INDEX);
59455946

59465947
if (vm == NULL)
59475948
return;
59485949

59495950
radeon_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3));
5950-
radeon_ring_write(ring, (WRITE_DATA_ENGINE_SEL(0) |
5951+
radeon_ring_write(ring, (WRITE_DATA_ENGINE_SEL(usepfp) |
59515952
WRITE_DATA_DST_SEL(0)));
59525953
if (vm->id < 8) {
59535954
radeon_ring_write(ring,
@@ -5997,7 +5998,7 @@ void cik_vm_flush(struct radeon_device *rdev, int ridx, struct radeon_vm *vm)
59975998
radeon_ring_write(ring, 1 << vm->id);
59985999

59996000
/* compute doesn't have PFP */
6000-
if (ridx == RADEON_RING_TYPE_GFX_INDEX) {
6001+
if (usepfp) {
60016002
/* sync PFP to ME, otherwise we might get invalid PFP reads */
60026003
radeon_ring_write(ring, PACKET3(PACKET3_PFP_SYNC_ME, 0));
60036004
radeon_ring_write(ring, 0x0);

drivers/gpu/drm/radeon/si.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -5013,7 +5013,7 @@ void si_vm_flush(struct radeon_device *rdev, int ridx, struct radeon_vm *vm)
50135013

50145014
/* write new base address */
50155015
radeon_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3));
5016-
radeon_ring_write(ring, (WRITE_DATA_ENGINE_SEL(0) |
5016+
radeon_ring_write(ring, (WRITE_DATA_ENGINE_SEL(1) |
50175017
WRITE_DATA_DST_SEL(0)));
50185018

50195019
if (vm->id < 8) {

0 commit comments

Comments
 (0)