forked from DefectDojo/django-DefectDojo
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathtest_finding_helper.py
244 lines (198 loc) · 9.92 KB
/
test_finding_helper.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
from .dojo_test_case import DojoTestCase
from dojo.models import Finding, Test, Vulnerability_Id, Finding_Template, Vulnerability_Id_Template
from django.contrib.auth.models import User
from unittest import mock
from unittest.mock import patch
from crum import impersonate
import datetime
from django.utils import timezone
import logging
from dojo.finding.helper import save_vulnerability_ids, save_vulnerability_ids_template
logger = logging.getLogger(__name__)
# frozen_datetime = timezone.make_aware(datetime.datetime(2021, 1, 1, 2, 2, 2), timezone.get_default_timezone())
frozen_datetime = timezone.now()
class TestUpdateFindingStatusSignal(DojoTestCase):
fixtures = ['dojo_testdata.json']
def setUp(self):
self.user_1 = User.objects.get(id='1')
self.user_2 = User.objects.get(id='2')
def get_status_fields(self, finding):
logger.debug('%s, %s, %s, %s, %s, %s, %s, %s', finding.active, finding.verified, finding.false_p, finding.out_of_scope, finding.is_mitigated, finding.mitigated, finding.mitigated_by, finding.last_status_update)
return finding.active, finding.verified, finding.false_p, finding.out_of_scope, finding.is_mitigated, finding.mitigated, finding.mitigated_by, finding.last_status_update
@mock.patch('dojo.finding.helper.timezone.now')
def test_new_finding(self, mock_tz):
mock_tz.return_value = frozen_datetime
with impersonate(self.user_1):
test = Test.objects.last()
finding = Finding(test=test)
finding.save()
self.assertEqual(
self.get_status_fields(finding),
(True, False, False, False, False, None, None, frozen_datetime)
)
@mock.patch('dojo.finding.helper.timezone.now')
def test_no_status_change(self, mock_tz):
mock_tz.return_value = frozen_datetime
with impersonate(self.user_1):
test = Test.objects.last()
finding = Finding(test=test)
finding.save()
status_fields = self.get_status_fields(finding)
finding.title = finding.title + '!!!'
finding.save()
self.assertEqual(
self.get_status_fields(finding),
status_fields
)
@mock.patch('dojo.finding.helper.timezone.now')
def test_mark_fresh_as_mitigated(self, mock_dt):
mock_dt.return_value = frozen_datetime
with impersonate(self.user_1):
test = Test.objects.last()
finding = Finding(test=test, is_mitigated=True, active=False)
finding.save()
self.assertEqual(
self.get_status_fields(finding),
(False, False, False, False, True, frozen_datetime, self.user_1, frozen_datetime)
)
@mock.patch('dojo.finding.helper.timezone.now')
@mock.patch('dojo.finding.helper.can_edit_mitigated_data', return_value=False)
def test_mark_old_active_as_mitigated(self, mock_can_edit, mock_tz):
mock_tz.return_value = frozen_datetime
with impersonate(self.user_1):
test = Test.objects.last()
finding = Finding(test=test, is_mitigated=True, active=False)
finding.save()
finding.is_mitigated = True
finding.active = False
finding.save()
self.assertEqual(
self.get_status_fields(finding),
(False, False, False, False, True, frozen_datetime, self.user_1, frozen_datetime)
)
@mock.patch('dojo.finding.helper.timezone.now')
@mock.patch('dojo.finding.helper.can_edit_mitigated_data', return_value=True)
def test_mark_old_active_as_mitigated_custom_edit(self, mock_can_edit, mock_tz):
mock_tz.return_value = frozen_datetime
custom_mitigated = datetime.datetime.now()
with impersonate(self.user_1):
test = Test.objects.last()
finding = Finding(test=test)
finding.save()
finding.is_mitigated = True
finding.active = False
finding.mitigated = custom_mitigated
finding.mitigated_by = self.user_2
finding.save()
self.assertEqual(
self.get_status_fields(finding),
(False, False, False, False, True, custom_mitigated, self.user_2, frozen_datetime)
)
@mock.patch('dojo.finding.helper.timezone.now')
@mock.patch('dojo.finding.helper.can_edit_mitigated_data', return_value=True)
def test_update_old_mitigated_with_custom_edit(self, mock_can_edit, mock_tz):
mock_tz.return_value = frozen_datetime
custom_mitigated = datetime.datetime.now()
with impersonate(self.user_1):
test = Test.objects.last()
finding = Finding(test=test, is_mitigated=True, active=False, mitigated=frozen_datetime, mitigated_by=self.user_1)
finding.save()
finding.is_mitigated = True
finding.active = False
finding.mitigated = custom_mitigated
finding.mitigated_by = self.user_2
finding.save()
self.assertEqual(
self.get_status_fields(finding),
(False, False, False, False, True, custom_mitigated, self.user_2, frozen_datetime)
)
@mock.patch('dojo.finding.helper.timezone.now')
@mock.patch('dojo.finding.helper.can_edit_mitigated_data', return_value=True)
def test_update_old_mitigated_with_missing_data(self, mock_can_edit, mock_tz):
mock_tz.return_value = frozen_datetime
custom_mitigated = datetime.datetime.now()
with impersonate(self.user_1):
test = Test.objects.last()
finding = Finding(test=test, is_mitigated=True, active=False, mitigated=custom_mitigated, mitigated_by=self.user_2)
finding.save()
finding.is_mitigated = True
finding.active = False
# trying to remove mitigated fields will trigger the signal to set them to now/current user
finding.mitigated = None
finding.mitigated_by = None
finding.save()
self.assertEqual(
self.get_status_fields(finding),
(False, False, False, False, True, frozen_datetime, self.user_1, frozen_datetime)
)
@mock.patch('dojo.finding.helper.timezone.now')
@mock.patch('dojo.finding.helper.can_edit_mitigated_data', return_value=True)
def test_set_old_mitigated_as_active(self, mock_can_edit, mock_tz):
mock_tz.return_value = frozen_datetime
with impersonate(self.user_1):
test = Test.objects.last()
finding = Finding(test=test, is_mitigated=True, active=False, mitigated=frozen_datetime, mitigated_by=self.user_2)
logger.debug('save1')
finding.save()
finding.active = True
logger.debug('save2')
finding.save()
self.assertEqual(
self.get_status_fields(finding),
(True, False, False, False, False, None, None, frozen_datetime)
)
@mock.patch('dojo.finding.helper.timezone.now')
@mock.patch('dojo.finding.helper.can_edit_mitigated_data', return_value=False)
def test_set_active_as_false_p(self, mock_can_edit, mock_tz):
mock_tz.return_value = frozen_datetime
with impersonate(self.user_1):
test = Test.objects.last()
finding = Finding(test=test)
finding.save()
finding.false_p = True
finding.save()
self.assertEqual(
self.get_status_fields(finding),
# TODO marking as false positive resets verified to False, possible bug / undesired behaviour?
(False, False, True, False, True, frozen_datetime, self.user_1, frozen_datetime)
)
@mock.patch('dojo.finding.helper.timezone.now')
@mock.patch('dojo.finding.helper.can_edit_mitigated_data', return_value=False)
def test_set_active_as_out_of_scope(self, mock_can_edit, mock_tz):
mock_tz.return_value = frozen_datetime
with impersonate(self.user_1):
test = Test.objects.last()
finding = Finding(test=test)
finding.save()
finding.out_of_scope = True
finding.save()
self.assertEqual(
self.get_status_fields(finding),
# TODO marking as false positive resets verified to False, possible bug / undesired behaviour?
(False, False, False, True, True, frozen_datetime, self.user_1, frozen_datetime)
)
class TestSaveVulnerabilityIds(DojoTestCase):
@patch('dojo.finding.helper.Vulnerability_Id.objects.filter')
@patch('django.db.models.query.QuerySet.delete')
@patch('dojo.finding.helper.Vulnerability_Id.save')
def test_save_vulnerability_ids(self, save_mock, delete_mock, filter_mock):
finding = Finding()
new_vulnerability_ids = ['REF-1', 'REF-2', 'REF-2']
filter_mock.return_value = Vulnerability_Id.objects.none()
save_vulnerability_ids(finding, new_vulnerability_ids)
filter_mock.assert_called_with(finding=finding)
delete_mock.assert_called_once()
self.assertEqual(save_mock.call_count, 2)
self.assertEqual('REF-1', finding.cve)
@patch('dojo.finding.helper.Vulnerability_Id_Template.objects.filter')
@patch('django.db.models.query.QuerySet.delete')
@patch('dojo.finding.helper.Vulnerability_Id_Template.save')
def test_save_vulnerability_id_templates(self, save_mock, delete_mock, filter_mock):
finding_template = Finding_Template()
new_vulnerability_ids = ['REF-1', 'REF-2', 'REF-2']
filter_mock.return_value = Vulnerability_Id_Template.objects.none()
save_vulnerability_ids_template(finding_template, new_vulnerability_ids)
filter_mock.assert_called_with(finding_template=finding_template)
delete_mock.assert_called_once()
self.assertEqual(save_mock.call_count, 2)
self.assertEqual('REF-1', finding_template.cve)