Skip to content

Commit 7c2ba18

Browse files
jonjohnsonjrgoogle-prow-robot
authored andcommitted
Clarify "happy state" condition types (knative#869)
It wasn't completely clear that "this" and "object name" refer to the condition Type.
1 parent 33ae9c0 commit 7c2ba18

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/spec/errors.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ should follow these patterns:
2828
2. Where it makes sense, resources should define a top-level "happy
2929
state" condition type which indicates that the resource is set up
3030
correctly and ready to serve. For long-running resources, this
31-
should be named `Ready`. For objects which run to completion, the
32-
object should be named `Succeeded`.
31+
condition type should be `Ready`. For objects which run to completion,
32+
the condition type should be `Succeeded`.
3333
3. Each condition's status should be one of:
3434
* `Unknown` when the controller is actively working to achieve the
3535
condition.

0 commit comments

Comments
 (0)